[R4R] update dependency and upgrade golang version #836
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yutianwu
reviewed
Jan 4, 2022
yutianwu
approved these changes
Jan 4, 2022
unclezoro
reviewed
Jan 4, 2022
| @@ -115,7 +115,7 @@ func (msg MintMsg) ValidateBasic() sdk.Error { | |||
|
|
|||
| // handler will check: msg.Amount + token.TotalSupply <= types.MaxTotalSupply | |||
| if msg.Amount <= 0 || msg.Amount > types.TokenMaxTotalSupply { | |||
| return sdk.ErrInvalidCoins("total supply should be less than or equal to " + string(types.TokenMaxTotalSupply)) | |||
| return sdk.ErrInvalidCoins("total supply should be less than or equal to " + strconv.FormatInt(types.TokenMaxTotalSupply, 10)) | |||
There was a problem hiding this comment.
encounter error when run unit tests - "plugins/tokens/issue/msg.go:59:80: conversion from int64 to string yields a string of one rune, not a string of digits (did you mean fmt.Sprint(x)?)"
unclezoro
approved these changes
Jan 4, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pr upgrades the dependencies of Tendermint and Cosmos-SDK; it also upgrades golang version to 1.16.
Rationale
To apply the new releases of BNC Tendermint and BNC Cosmos-SDK , which include some important fixes.
Example
n/a
Changes