BEP8 Mini-BEP2 token features #725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 17 commits
March 23, 2020 20:08
EnderCrypto
force-pushed
the
mini_token_bak
branch
5 times, most recently
from
7963ebf to
34ba52d
Compare
EnderCrypto
force-pushed
the
mini_token_bak
branch
from
34ba52d to
d92a2ca
Compare
EnderCrypto
force-pushed
the
mini_token_bak
branch
from
dc17212 to
da397b1
Compare
EnderCrypto
force-pushed
the
mini_token_bak
branch
from
e43cf1e to
b4ac188
Compare
rickyyangz
reviewed
May 8, 2020
plugins/tokens/route.go
Outdated
| routes[issue.Route] = issue.NewHandler(tokenMapper, keeper) | ||
| routes[burn.BurnRoute] = burn.NewHandler(tokenMapper, keeper) | ||
| routes[freeze.FreezeRoute] = freeze.NewHandler(tokenMapper, accKeeper, keeper) | ||
| routes[issue.Route] = issue.NewHandler(tokenMapper, miniTokenMapper, keeper) |
There was a problem hiding this comment.
can we add a TokenKeeper including all these mappers and other related keepers
rickyyangz
reviewed
May 8, 2020
plugins/tokens/swap/handler.go
Outdated
| @@ -27,6 +29,10 @@ func NewHandler(kp Keeper) sdk.Handler { | |||
| } | |||
|
|
|||
| func handleHashTimerLockedTransfer(ctx sdk.Context, kp Keeper, msg HTLTMsg) sdk.Result { | |||
| symbolError := types.ValidateMapperTokenCoins(msg.Amount) | |||
There was a problem hiding this comment.
why do we need to add this check for existing bep2 tokens
ackratos
reviewed
May 31, 2020
go.mod
Outdated
| @@ -29,7 +29,7 @@ require ( | |||
| ) | |||
|
|
|||
| replace ( | |||
| github.com/cosmos/cosmos-sdk => github.com/binance-chain/bnc-cosmos-sdk v0.25.0-binance.20 | |||
| github.com/cosmos/cosmos-sdk => github.com/binance-chain/bnc-cosmos-sdk v0.19.1-0.20200529110602-b9a19ff527bf | |||
There was a problem hiding this comment.
why are we moving backwards
There was a problem hiding this comment.
Will merge to the lastest cosmos sdk
ackratos
reviewed
May 31, 2020
rickyyangz
reviewed
Jun 2, 2020
|
|
||
| "github.com/binance-chain/node/common/types" | ||
| "github.com/binance-chain/node/common/upgrade" | ||
| tokenStore "github.com/binance-chain/node/plugins/tokens/store" |
There was a problem hiding this comment.
please do not reference the token plugin in list plugin
rickyyangz
reviewed
Jun 2, 2020
plugins/dex/list/msg_mini.go
Outdated
| InitPrice int64 `json:"init_price"` | ||
| } | ||
|
|
||
| func NewMiniMsg(from sdk.AccAddress, baseAssetSymbol string, quoteAssetSymbol string, initPrice int64) ListMiniMsg { |
ackratos
reviewed
Jun 2, 2020
| err = cdc.UnmarshalBinaryLengthPrefixed(bz, &tokens) | ||
| if err != nil { | ||
| fmt.Println(err) |
Merged
|
good project |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Similar to SME board in the traditional stock markets, introducing Mini-BEP2 Tokens is to benefit the below scenarios in which the normal BEP2 tokens are expensive and not convenient to issue/list:
Rationale
Different from the normal BEP2, using a mini-token system is good at:
Example
Changes
Notable changes:
New Transactions for Mini token
bnbcli token issue-tiny
bnbcli token issue-mini
bnbcli token set-uri-mini
bnbcli dex list-mini
Existing Transactions supporting Mini token
burn
mint
freeze
unfreeze
new order
cancel order
delist
New RPC API for mini token
/mini-tokens/info/mini-tokens/list/dex-mini/pairsExisting RPC API supporting mini token
/dex/orderbook/dex/openordersPreflight checks
make build)make test)make integration_test)Already reviewed by
...
Related issues
bnb-chain/BEPs#69