Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Regression] Update icon paths for Signal systray images. #772

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zquestz
Copy link

@zquestz zquestz commented Oct 28, 2023

This PR updates signal.electron.json to swap the signal-desktop systray icons.

Fixes #771

@abouvier
Copy link
Contributor

signal-desktop now uses these files:

images/tray-icons/base/signal-tray-icon-16x16-base.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-1.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-2.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-3.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-4.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-5.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-6.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-7.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-8.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-9.png
images/tray-icons/alert/signal-tray-icon-16x16-alert-9+.png

@zquestz zquestz changed the title [Regression] Update icon paths for Signal to point to 32px versions. [Regression] Update icon paths for Signal systray images. Nov 21, 2024
@zquestz
Copy link
Author

zquestz commented Nov 21, 2024

@abouvier thanks for the heads-up. I have updated the PR to work with their new image layout, however it seems something is wrong decompressing their app.asar file with the latest release!

I am getting the following errors trying to apply the new icons. That being said, it appears the icon swap still works.

warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/better-sqlite3/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/better-sqlite3/build/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/better-sqlite3/build/Release/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/better-sqlite3/build/Release/better_sqlite3.node
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/libsignal-client/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/libsignal-client/prebuilds/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/libsignal-client/prebuilds/linux-x64/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/libsignal-client/prebuilds/linux-x64/@signalapp+libsignal-client.node
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/ringrtc/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/ringrtc/build/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/ringrtc/build/linux/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/@signalapp/ringrtc/build/linux/libringrtc-x64.node
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/fs-xattr/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/fs-xattr/build/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/fs-xattr/build/Release/
warning: could not get file information for usr/lib/signal-desktop/resources/app.asar.unpacked/node_modules/fs-xattr/build/Release/xattr.node

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signal Desktop Regression
2 participants