[BUG] Persistent info not updating

[rondlh]

Description

I noticed that under certain conditions the persistent info is not updating.

Steps to reproduce

1. Let temps stabilize at room temp
2. Increase the E1 target temp (IDEX system)
3. Watch the shown persistent temp for E1

Expected behavior
Persistent temp updates correctly

Actual behavior
E1 temp is not updated

Hardware Variant

BTT TFT35 V3.0

TFT Firmware Version & Main Board Firmware details

Latest release (2023-06-05)

Additional Information

The issue seems to be in PersistentInfo.c

  uint8_t tmpHeater[3];  // chamber, bed, hotend
  uint8_t tmpIndex = 0;

  if (infoSettings.hotend_count)  // global hotend
    tmpHeater[tmpIndex++] = heatGetCurrentHotend();

  if (infoSettings.bed_en)  // global bed
    tmpHeater[tmpIndex++] = BED;

  if (infoSettings.chamber_en)  // global chamber
    tmpHeater[tmpIndex++] = CHAMBER;

  bool update = false;
  static int16_t lastCurrent[3];
  static int16_t lastTarget[3];

  for (int8_t i = tmpIndex - 1; i >= 0; i--)
  {
    int16_t actCurrent = heatGetCurrentTemp(tmpHeater[i]);
    int16_t actTarget = heatGetTargetTemp(tmpHeater[i]);

    if (lastCurrent[i] != actCurrent || lastTarget[i] != actTarget)
    {
      lastCurrent[i] = actCurrent;
      lastTarget[i] = actTarget;
      update = true;
   }
  }

To check if an update of the persistent info is needed, only the E0 temp/target, bed temp/target and chamber temp/target are used, not the E1 temp/target.

[kisslorand]

@rondlh
Please check PR #2805.

[rondlh]

@rondlh Please check PR #2805.

That's a very nice solution, which handles the various configurations quite well.

[rondlh]

Solved, thanks to @kisslorand

[github-actions]

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.