Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Clarify that hx-include does not include disabled inputs #3053

Open
fpecserke opened this issue Dec 2, 2024 · 2 comments
Open

[Docs] Clarify that hx-include does not include disabled inputs #3053

fpecserke opened this issue Dec 2, 2024 · 2 comments
Labels
documentation Improvements or additions to documentation help wanted We would be interested in a PR that resolves that issue

Comments

@fpecserke
Copy link

Problem Definition

Hi, I just spent 2 hours debugging why the values are not included, until I realized that the reason is there is a disabled tag in my element (I don't want it to be editable). I replaced it with readonly and it worked.

Spec compliance

This behavior is up to spec.

Suggested solution

I just want to add this info to the docs under Notes to save people's time when they have a similar use-case and lack of knowledge in web standards just like me.

Similar issues

Similar issues were submitted in the past (#2158 - form data overriding hx-include , #2384 - name attribute required) but this is a separate problem.

I am willing to create a PR for all of them, as it is a simple docs change and is appropriate for my first commit.

@Telroshan Telroshan added the documentation Improvements or additions to documentation label Dec 3, 2024
@Telroshan
Copy link
Collaborator

Hello, sure, sounds like a common gotcha. Feel free to open a documentation PR!

@Telroshan Telroshan added the help wanted We would be interested in a PR that resolves that issue label Dec 7, 2024
@fpecserke
Copy link
Author

Okay, I am on it .. I will spend some time on it, if anyone wants to add something else to add, let me know

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation help wanted We would be interested in a PR that resolves that issue
Projects
None yet
Development

No branches or pull requests

2 participants