Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datagram example magic value doesn't appear to be used #104

Open
jbobrow opened this issue Mar 26, 2021 · 2 comments
Open

Datagram example magic value doesn't appear to be used #104

jbobrow opened this issue Mar 26, 2021 · 2 comments

Comments

@jbobrow
Copy link
Contributor

jbobrow commented Mar 26, 2021

I think this code intends to set the magic value when a datagram is confirmed to be received completely, but right now, it looks like it is always sharing that magic value. This could be a misunderstanding on my part as well.

@jbobrow
Copy link
Contributor Author

jbobrow commented Mar 26, 2021

'F-SimpleDatagramDemo' for reference

@bigjosh
Copy link
Owner

bigjosh commented Mar 27, 2021

I believe the code is as intended, which might be overly complicated for this example.

The idea is to show the difference between how face values and datagram messages work (face values are continuously sent while datagrams are sent once). The 42 is set as the face value on all faces so it is sent continuously whenever a datagram is not being transmitted. On the receiving side, a 42 is shown as green to indicate that we successfully got the intended face value value from the other side, just as we show blue if we successfully got the intended datagram value ("CAT") from the other side.

Make sense?

Now all those misspellings are definately inexcusable! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants