Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update TipTap to v2.6.0 or latest to include the improvements in React NodeView. #1214

Closed
2 tasks done
deepakjosp opened this issue Sep 2, 2024 · 0 comments · Fixed by #1218
Closed
2 tasks done

Update TipTap to v2.6.0 or latest to include the improvements in React NodeView. #1214

deepakjosp opened this issue Sep 2, 2024 · 0 comments · Fixed by #1218
Assignees
@deepakjosp
Labels
0.5D Estimate - 4 hours PR The issue has a PR associated with it.

Comments

@deepakjosp
Copy link
Contributor

deepakjosp commented Sep 2, 2024 •
edited
Loading

When checked the changelog, I could see they have fixed some major React NodeView performacnce issues. Let's update to the latest release so that we can make use of the improvements. Apart from that there are few minor fixes.

  • Update TipTap to v2.6.0 or latest.
  • Since they have stated that it will bring in some significant improvements, let's remove the optimizations that we introduced in the Image and CodeBlock React NodeViews.

@AbhayVAshokan please check and let me know your opinion.

0.5D _t

@deepakjosp _a
@neetogit-bot neetogit-bot bot added the 0.5D Estimate - 4 hours label Sep 2, 2024
@deepakjosp deepakjosp changed the title Update TipTap to v2.6.0 or latest to incorporat the improvements in React NodeView. Update TipTap to v2.6.0 or latest to include the improvements in React NodeView. Sep 2, 2024
@neetogit-bot neetogit-bot bot added working A branch associated with this issue is created. PR The issue has a PR associated with it. labels Sep 16, 2024
@deepakjosp deepakjosp mentioned this issue Sep 16, 2024
Merged
4 tasks
@neetogit-bot neetogit-bot bot removed the working A branch associated with this issue is created. label Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deepakjosp deepakjosp

Labels
0.5D Estimate - 4 hours PR The issue has a PR associated with it.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Updates TipTap to v2.6.6. bigbinary/neeto-editor
1 participant
@deepakjosp