Allow Snowbridge bridged ERC20 Reserves from Asset Hub #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ark930
approved these changes
May 22, 2024
acatangiu
reviewed
Jul 24, 2024
Comment on lines
+506
to
+509
| /// Matches foreign assets from a given origin. | ||
| /// Foreign assets are assets bridged from other consensus systems. i.e parents > 1. | ||
| pub struct IsForeignNativeAssetFrom<Origin>(PhantomData<Origin>); | ||
| impl<Origin> ContainsPair<MultiAsset, MultiLocation> for IsForeignNativeAssetFrom<Origin> |
There was a problem hiding this comment.
Not all foreign assets are bridged from other ecosystems.
I suggest you change this comment and structure name to something like:
Suggested change
| /// Matches foreign assets from a given origin. | |
| /// Foreign assets are assets bridged from other consensus systems. i.e parents > 1. | |
| pub struct IsForeignNativeAssetFrom<Origin>(PhantomData<Origin>); | |
| impl<Origin> ContainsPair<MultiAsset, MultiLocation> for IsForeignNativeAssetFrom<Origin> | |
| /// Matches bridged assets from a given origin. | |
| /// Assets bridged from other consensus systems. i.e parents == 2. | |
| pub struct IsBridgedAssetFrom<Origin>(PhantomData<Origin>); | |
| impl<Origin> ContainsPair<MultiAsset, MultiLocation> for IsBridgedAssetFrom<Origin> |
3 tasks
3 tasks
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows assets from different consensus systems (parents > 1) to be reserve deposited from Asset Hub as a reserve. Asset Hub acts as a reserve for bridged assets bridged using Bridge Hub and that means that this PR will also allow Asset Hub to be the reserve for assets bridged by the Polkadot <-> Kusama bridge.