Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SCHEMA] Add v1.10.0 to known BIDS versions list #1994

Merged
merged 1 commit into from
Dec 5, 2024
Merged

[SCHEMA] Add v1.10.0 to known BIDS versions list #1994

merged 1 commit into from
Dec 5, 2024

Conversation

jeffersoncasimir
Copy link
Contributor

@jeffersoncasimir jeffersoncasimir commented Nov 28, 2024 •
edited
Loading

This PR adds BIDS version 1.10.0 to src/schema/meta/versions.yaml to address the following bug:

The bids-validator throws an UNKNOWN_BIDS_VERSION warning for datasets with "BIDSVersion" : "1.10.0"

@christinerogers
Copy link
Contributor

christinerogers commented Dec 5, 2024 •
edited
Loading

@Remi-Gau @effigies is this a no-brainer? (failing check aside)

@effigies effigies added schema Issues related to the YAML schema representation of the specification. Patch version release. exclude-from-changelog This item will not feature in the automatically generated changelog labels Dec 5, 2024
@effigies
Copy link
Collaborator

effigies commented Dec 5, 2024

Yes. We need to add this to the Release protocol so that this is part of the released schema.

@effigies effigies merged commit 86e331c into bids-standard:master Dec 5, 2024
25 of 26 checks passed
effigies pushed a commit that referenced this pull request Dec 5, 2024
@jeffersoncasimir @effigies
FIX: Add 1.10.0 to known versions list (#1994)
188da09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@effigies effigies effigies approved these changes

@erdalkaraca erdalkaraca Awaiting requested review from erdalkaraca erdalkaraca is a code owner

Assignees
No one assigned
Labels
exclude-from-changelog This item will not feature in the automatically generated changelog schema Issues related to the YAML schema representation of the specification. Patch version release.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jeffersoncasimir @christinerogers @effigies