-
-
Notifications
You must be signed in to change notification settings - Fork 229
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attributes from URLs overwritten when used with plyr #396
Comments
Yeah, that is a bit odd. It should be easy enough to fix, just need to make sure Plyr isn't to blame in some capacity |
GLightbox simply passes the full url to Plyr, there's a simple check to see if the video is vimeo or youtube but that's it. Plyr receives the full URL to process it. If you can provide an example it would be great, but i think there's nothing we can do on our end. |
Hi, |
Hello, it's a Plyr bug which I reported here There is also a fix but not yet merged into the master. |
@despecial Thanks for looking into that! I know that Plyr is in the process of joining VidStack, but hopefully they merge that before then. |
Projects not listed as publicly available via their embed options on Vimeo require an attribute in the URL to play.
Public:https://player.vimeo.com/video/111111111
Hidden: https://player.vimeo.com/video/111111111?h=1111111111
When passing an href with an attribute to an anchor tag href attribute, the resulting lightbox overlay using plyr overwrites the attribute required for hidden videos to play. This results in the video being unable to be found on Vimeo and not playing.
Expected behaviour would be to append rather than overwrite any attributes in the href.
Cross-device behaviour
The text was updated successfully, but these errors were encountered: