Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attributes from URLs overwritten when used with plyr #396

Open
ocripps24 opened this issue Jan 5, 2023 · 5 comments
Open

Attributes from URLs overwritten when used with plyr #396

ocripps24 opened this issue Jan 5, 2023 · 5 comments

Comments

@ocripps24
Copy link

ocripps24 commented Jan 5, 2023

Projects not listed as publicly available via their embed options on Vimeo require an attribute in the URL to play.

Public:https://player.vimeo.com/video/111111111
Hidden: https://player.vimeo.com/video/111111111?h=1111111111

When passing an href with an attribute to an anchor tag href attribute, the resulting lightbox overlay using plyr overwrites the attribute required for hidden videos to play. This results in the video being unable to be found on Vimeo and not playing.

Expected behaviour would be to append rather than overwrite any attributes in the href.

Cross-device behaviour

@gingerchew
Copy link
Collaborator

Yeah, that is a bit odd. It should be easy enough to fix, just need to make sure Plyr isn't to blame in some capacity

@biati-digital
Copy link
Owner

GLightbox simply passes the full url to Plyr, there's a simple check to see if the video is vimeo or youtube but that's it. Plyr receives the full URL to process it. If you can provide an example it would be great, but i think there's nothing we can do on our end.

@Lefthandmedia
Copy link

Hi,
I'm pretty sure PLYR cannot consume playlists. so the option is to not use PLYR for playlists and use the standard YT embed only when it is a YT playlist. Is that an option?

@despecial
Copy link

Hello, it's a Plyr bug which I reported here
sampotts/plyr#2606

There is also a fix but not yet merged into the master.

@gingerchew
Copy link
Collaborator

@despecial Thanks for looking into that! I know that Plyr is in the process of joining VidStack, but hopefully they merge that before then.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants