Valid json but not well formated, cloud not be parsed

[briceruzand]

The following valid json could not be parsed by jsonview 1.2.0.

https://gist.github.com/briceruzand/2481a83e739cea80a48b0d51ba93127b

I got the following error :
expected ':' after property name in object at line 5 column 14

[bhollis]

I guarantee it's not valid json.

…

-Ben

On Dec 21, 2016, at 9:34 AM, Bryce ***@***.***> wrote: The following valid json could not be parsed by jsonview 1.2.0. https://gist.github.com/briceruzand/2481a83e739cea80a48b0d51ba93127b I got the following error : expected ':' after property name in object at line 5 column 14 ― You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

[briceruzand]

Are you sure, because every jsonlint (validator) I try with that json tells it is a valid one. What is unvalid is that json ?

Thx

[bhollis]

You probably have some nonprintable character in there. I'd need to see the original document to be sure - whatever's in the Gist is valid, so it's not what JSONView is choking on.

[stanio]

Looks caused by the source tweaking done in safeStringEncodeNums() – the result becomes:

{
  "status" : "ok",
"sort_by" : "asc",
"filters" : [],
"data" : {"i"​18"n":"label"}
}

[stanio]

So this looks related to #21 / 808e99f. It fails to recognize the number is part of a string key, in the given case.

IMO, the fix for #21 should only target large integer numbers (18+ decimal digits), while it appears to match any JSON number literal (including floating point numbers).

[bhollis]

Good catch! I'll see if I can tweak that refer. I've had no end of trouble with that patch.

…

-Ben

On Jan 7, 2017, at 5:09 AM, Stanimir Stamenkov ***@***.***> wrote: So this looks related to #21 / 808e99f. It fails to recognize the number is part of a string key, in the given case. IMO, the fix for #21 should only target large integer numbers (18+ decimal digits), while it appears to match any JSON number literal (including floating point numbers). ― You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

[bhollis]

OK, it turned out to be a weird edge case in the regex to count quotes, not the number regex. I've fixed it. Sorry for doubting your issue, and thanks for sticking with it and helping fix a real bug!

[briceruzand]

Thank you guys for fixing this trouble.
Will you pulish a new release shortly with that fix ?

[stanio]

I already see it available at:

https://addons.mozilla.org/addon/jsonview/versions/

Probably it awaits formal AMO approval to appear directly on:

https://addons.mozilla.org/addon/jsonview/

[bhollis]

It has just been approved.

…

-Ben

On Jan 9, 2017, at 1:49 AM, Stanimir Stamenkov ***@***.***> wrote: I already see it available at: https://addons.mozilla.org/addon/jsonview/versions/ Probably it awaits formal AMO approval to appear directly on: https://addons.mozilla.org/addon/jsonview/ ― You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub, or mute the thread.

[stanio]

Unrelated... I've noticed the extension is marked that it doesn't require restart, but then JS updates don't really take effect until application gets restarted.

[briceruzand]

Thx very much my ugly json stream can now be visualized.