Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump MSRV to 1.60 for csv dependency #665

Merged
merged 5 commits into from
Apr 2, 2023
Merged

Bump MSRV to 1.60 for csv dependency #665

merged 5 commits into from
Apr 2, 2023

Conversation

nbarrios1337
Copy link
Contributor

No description provided.

@nbarrios1337 nbarrios1337 mentioned this pull request Mar 31, 2023
Merged
@lemmih
Copy link
Collaborator

lemmih commented Mar 31, 2023

Hmm, I don't know why the CI fails.

@nbarrios1337
Copy link
Contributor Author

nbarrios1337 commented Mar 31, 2023 •
edited
Loading

I've found recent criterion.rs PRs merge through regardless of the failing appveyor CI. However, the "unknown" error from the GHA run is unclear to me as well.

Edit: doing some WIP ci debugging at nbarrios1337#2

@nbarrios1337
Copy link
Contributor Author

nbarrios1337 commented Mar 31, 2023 •
edited
Loading

The CI here and over on nbarrios1337#2 successfully builds and tests (until canceled at least) across all tested toolchains, but fails on clippy lints on the stable toolchain run.

I can go ahead and fix those lints; Are there some nuances for the criterion.rs source code where I should place an #[allow(...)] for lints that can be specifically ignored?

@lemmih
Copy link
Collaborator

lemmih commented Apr 1, 2023

I can go ahead and fix those lints; Are there some nuances for the criterion.rs source code where I should place an #[allow(...)] for lints that can be specifically ignored?

Everything can probably be fixed.

@nbarrios1337
cargo clippy --fix
4c60859 
Note: the PlottingBackend Box change and the criterion_tests import change were made manually to pass through rustc aborts after automatic fix attempts.
@nbarrios1337 nbarrios1337 mentioned this pull request Apr 1, 2023
Closed
@lemmih lemmih merged commit a844eb2 into bheisler:master Apr 2, 2023
nbarrios1337 added a commit to nbarrios1337/criterion.rs that referenced this pull request May 13, 2023
@nbarrios1337
Correct CHANGELOG mistake from bheisler#665
59c78ce 
Misplaced the MSRV bump changelog update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lemmih lemmih lemmih approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbarrios1337 @lemmih