feat: rates base payload and factory for v2 #68

brotherlymite · 2023-03-10T07:09:06Z

Added AaveV2ConfigEngine to update rates using factory on aave-v2.
Added V2RateStrategyFactory similar to V3RateStrategyFactory but with minor differences in params.
DeployV2RatesFactoryLib deploys the factory and initialises only standard strategies by comparing the contract bytecode length.

…or v2

github-actions · 2023-03-10T07:11:01Z

Foundry report

forge 0.2.0 (cc5637a 2023-06-02T00:09:46.708013335Z)

Build log

installing solc version "0.8.20"
Successfully installed solc 0.8.20
Compiling 166 files with 0.8.20
Solc 0.8.20 finished in 47.74s
Compiler run �[33msuccessful with warnings:�[0m
�[1;33mWarning (8760)�[0m�[1;37m: This declaration has the same name as another declaration.�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:60:5:
�[34m   |�[0m
�[34m60 |�[0m     �[33muint256 baseVariableBorrowRate�[0m,
�[34m   |�[0m     �[1;33m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;36mNote�[0m�[1;37m: The other declaration is here:�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:92:3:
�[34m   |�[0m
�[34m92 |�[0m   �[33mfunction baseVariableBorrowRate() external view override returns (uint256) {�[0m
�[34m   |�[0m   �[1;33m^ (Relevant source part starts here and spans across multiple lines).�[0m

�[1;33mWarning (8760)�[0m�[1;37m: This declaration has the same name as another declaration.�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:61:5:
�[34m   |�[0m
�[34m61 |�[0m     �[33muint256 variableRateSlope1�[0m,
�[34m   |�[0m     �[1;33m^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;36mNote�[0m�[1;37m: The other declaration is here:�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:76:3:
�[34m   |�[0m
�[34m76 |�[0m   �[33mfunction variableRateSlope1() external view returns (uint256) {�[0m
�[34m   |�[0m   �[1;33m^ (Relevant source part starts here and spans across multiple lines).�[0m

�[1;33mWarning (8760)�[0m�[1;37m: This declaration has the same name as another declaration.�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:62:5:
�[34m   |�[0m
�[34m62 |�[0m     �[33muint256 variableRateSlope2�[0m,
�[34m   |�[0m     �[1;33m^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;36mNote�[0m�[1;37m: The other declaration is here:�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:80:3:
�[34m   |�[0m
�[34m80 |�[0m   �[33mfunction variableRateSlope2() external view returns (uint256) {�[0m
�[34m   |�[0m   �[1;33m^ (Relevant source part starts here and spans across multiple lines).�[0m

�[1;33mWarning (8760)�[0m�[1;37m: This declaration has the same name as another declaration.�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:63:5:
�[34m   |�[0m
�[34m63 |�[0m     �[33muint256 stableRateSlope1�[0m,
�[34m   |�[0m     �[1;33m^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;36mNote�[0m�[1;37m: The other declaration is here:�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:84:3:
�[34m   |�[0m
�[34m84 |�[0m   �[33mfunction stableRateSlope1() external view returns (uint256) {�[0m
�[34m   |�[0m   �[1;33m^ (Relevant source part starts here and spans across multiple lines).�[0m

�[1;33mWarning (8760)�[0m�[1;37m: This declaration has the same name as another declaration.�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:64:5:
�[34m   |�[0m
�[34m64 |�[0m     �[33muint256 stableRateSlope2�[0m
�[34m   |�[0m     �[1;33m^^^^^^^^^^^^^^^^^^^^^^^^�[0m
�[1;36mNote�[0m�[1;37m: The other declaration is here:�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:88:3:
�[34m   |�[0m
�[34m88 |�[0m   �[33mfunction stableRateSlope2() external view returns (uint256) {�[0m
�[34m   |�[0m   �[1;33m^ (Relevant source part starts here and spans across multiple lines).�[0m

�[1;33mWarning (2462)�[0m�[1;37m: Visibility for constructor is ignored. If you want the contract to be non-deployable, making it "abstract" is sufficient.�[0m
  �[34m-->�[0m src/dependencies/DefaultReserveInterestRateStrategy.sol:57:3:
�[34m   |�[0m
�[34m57 |�[0m   �[33mconstructor(�[0m
�[34m   |�[0m   �[1;33m^ (Relevant source part starts here and spans across multiple lines).�[0m

�[1;33mWarning (9302)�[0m�[1;37m: Return value of low-level calls not used.�[0m
   �[34m-->�[0m src/test/crosschainforwarders/ArbitrumCrossChainForwarderTest.t.sol:139:5:
�[34m    |�[0m
�[34m139 |�[0m     �[33mARBITRUM_BRIDGE_EXECUTOR.call(payload)�[0m;
�[34m    |�[0m     �[1;33m^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^�[0m

| Contract                                    | Size (kB) | Margin (kB) |
|---------------------------------------------|-----------|-------------|
| AaveGovernanceV2                            | 0.272     | 24.304      |
| AaveMisc                                    | 0.086     | 24.49       |
| AaveV2Avalanche                             | 0.086     | 24.49       |
| AaveV2AvalancheAssets                       | 0.086     | 24.49       |
| AaveV2ConfigEngine                          | 3.18      | 21.396      |
| AaveV2Ethereum                              | 0.086     | 24.49       |
| AaveV2EthereumAMM                           | 0.086     | 24.49       |
| AaveV2EthereumAMMAssets                     | 0.086     | 24.49       |
| AaveV2EthereumArc                           | 0.086     | 24.49       |
| AaveV2EthereumAssets                        | 0.086     | 24.49       |
| AaveV2EthereumRatesUpdate                   | 1.712     | 22.864      |
| AaveV2Fuji                                  | 0.086     | 24.49       |
| AaveV2FujiAssets                            | 0.086     | 24.49       |
| AaveV2Goerli                                | 0.086     | 24.49       |
| AaveV2GoerliAssets                          | 0.086     | 24.49       |
| AaveV2Mumbai                                | 0.086     | 24.49       |
| AaveV2MumbaiAssets                          | 0.086     | 24.49       |
| AaveV2Polygon                               | 0.086     | 24.49       |
| AaveV2PolygonAssets                         | 0.086     | 24.49       |
| AaveV3Arbitrum                              | 0.086     | 24.49       |
| AaveV3ArbitrumAssets                        | 0.086     | 24.49       |
| AaveV3ArbitrumGoerli                        | 0.086     | 24.49       |
| AaveV3ArbitrumGoerliAssets                  | 0.086     | 24.49       |
| AaveV3ArbitrumRatesUpdates070322            | 4.554     | 20.022      |
| AaveV3Avalanche                             | 0.086     | 24.49       |
| AaveV3AvalancheAssets                       | 0.086     | 24.49       |
| AaveV3AvalancheCollateralUpdate             | 3.012     | 21.564      |
| AaveV3AvalancheCollateralUpdateCorrectBonus | 3.012     | 21.564      |
| AaveV3AvalancheCollateralUpdateNoChange     | 3.032     | 21.544      |
| AaveV3AvalancheCollateralUpdateWrongBonus   | 3.012     | 21.564      |
| AaveV3AvalancheRatesUpdates070322           | 5.119     | 19.457      |
| AaveV3ConfigEngine                          | 21.129    | 3.447       |
| AaveV3Ethereum                              | 0.086     | 24.49       |
| AaveV3EthereumAssets                        | 0.086     | 24.49       |
| AaveV3EthereumMockCapUpdate                 | 2.92      | 21.656      |
| AaveV3EthereumMockCustomListing             | 3.919     | 20.657      |
| AaveV3Fantom                                | 0.086     | 24.49       |
| AaveV3FantomAssets                          | 0.086     | 24.49       |
| AaveV3FantomTestnet                         | 0.086     | 24.49       |
| AaveV3FantomTestnetAssets                   | 0.086     | 24.49       |
| AaveV3Fuji                                  | 0.086     | 24.49       |
| AaveV3FujiAssets                            | 0.086     | 24.49       |
| AaveV3Goerli                                | 0.086     | 24.49       |
| AaveV3GoerliAssets                          | 0.086     | 24.49       |
| AaveV3GoerliGho                             | 0.086     | 24.49       |
| AaveV3GoerliGhoAssets                       | 0.086     | 24.49       |
| AaveV3Harmony                               | 0.086     | 24.49       |
| AaveV3HarmonyAssets                         | 0.086     | 24.49       |
| AaveV3Metis                                 | 0.086     | 24.49       |
| AaveV3MetisAssets                           | 0.086     | 24.49       |
| AaveV3Mumbai                                | 0.086     | 24.49       |
| AaveV3MumbaiAssets                          | 0.086     | 24.49       |
| AaveV3Optimism                              | 0.086     | 24.49       |
| AaveV3OptimismAssets                        | 0.086     | 24.49       |
| AaveV3OptimismGoerli                        | 0.086     | 24.49       |
| AaveV3OptimismGoerliAssets                  | 0.086     | 24.49       |
| AaveV3OptimismMockRatesUpdate               | 3.254     | 21.322      |
| AaveV3OptimismRatesUpdates070322            | 4.133     | 20.443      |
| AaveV3Polygon                               | 0.086     | 24.49       |
| AaveV3PolygonAssets                         | 0.086     | 24.49       |
| AaveV3PolygonBorrowUpdate                   | 3.005     | 21.571      |
| AaveV3PolygonMockListing                    | 3.731     | 20.845      |
| AaveV3PolygonPriceFeedUpdate                | 2.856     | 21.72       |
| AaveV3PolygonRatesUpdates070322             | 5.858     | 18.718      |
| AaveV3ScrollAlpha                           | 0.086     | 24.49       |
| AaveV3ScrollAlphaAssets                     | 0.086     | 24.49       |
| AaveV3Sepolia                               | 0.086     | 24.49       |
| AaveV3SepoliaAssets                         | 0.086     | 24.49       |
| Address                                     | 0.086     | 24.49       |
| AddressAliasHelper                          | 0.086     | 24.49       |
| CapsPlusRiskSteward                         | 2.607     | 21.969      |
| CapsPlusRiskStewardErrors                   | 0.556     | 24.02       |
| ChainIds                                    | 0.086     | 24.49       |
| ConfiguratorInputTypes                      | 0.086     | 24.49       |
| CrosschainForwarderArbitrum                 | 2.246     | 22.33       |
| CrosschainForwarderMetis                    | 1.561     | 23.015      |
| CrosschainForwarderOptimism                 | 1.689     | 22.887      |
| CrosschainForwarderPolygon                  | 1.435     | 23.141      |
| DataTypes                                   | 0.086     | 24.49       |
| DefaultReserveInterestRateStrategy          | 3.469     | 21.107      |
| DeployEngineArbLib                          | 0.086     | 24.49       |
| DeployEngineAvaLib                          | 0.086     | 24.49       |
| DeployEngineEthLib                          | 0.086     | 24.49       |
| DeployEngineMetLib                          | 0.086     | 24.49       |
| DeployEngineOptLib                          | 0.086     | 24.49       |
| DeployEnginePolLib                          | 0.086     | 24.49       |
| DeployRatesFactoryArbLib                    | 0.086     | 24.49       |
| DeployRatesFactoryAvaLib                    | 0.086     | 24.49       |
| DeployRatesFactoryEthLib                    | 0.086     | 24.49       |
| DeployRatesFactoryLib                       | 0.086     | 24.49       |
| DeployRatesFactoryMetLib                    | 0.086     | 24.49       |
| DeployRatesFactoryOptLib                    | 0.086     | 24.49       |
| DeployRatesFactoryPolLib                    | 0.086     | 24.49       |
| DeployV2EngineAvaLib                        | 0.086     | 24.49       |
| DeployV2EngineEthAMMLib                     | 0.086     | 24.49       |
| DeployV2EngineEthLib                        | 0.086     | 24.49       |
| DeployV2EnginePolLib                        | 0.086     | 24.49       |
| DeployV2RatesFactoryAvaLib                  | 0.086     | 24.49       |
| DeployV2RatesFactoryEthAMMLib               | 0.086     | 24.49       |
| DeployV2RatesFactoryEthLib                  | 0.086     | 24.49       |
| DeployV2RatesFactoryLib                     | 0.086     | 24.49       |
| DeployV2RatesFactoryPolLib                  | 0.086     | 24.49       |
| EngineFlags                                 | 0.086     | 24.49       |
| Errors                                      | 3.952     | 20.624      |
| FxChild                                     | 1.039     | 23.537      |
| FxRoot                                      | 0.811     | 23.765      |
| GovHelpers                                  | 0.086     | 24.49       |
| MockExecutor                                | 0.437     | 24.139      |
| PayloadWithEmit                             | 0.15      | 24.426      |
| PercentageMath                              | 0.086     | 24.49       |
| ProxyHelpers                                | 0.086     | 24.49       |
| ReserveConfiguration                        | 0.171     | 24.405      |
| SafeMath                                    | 0.086     | 24.49       |
| StdInvariant                                | 2.038     | 22.538      |
| StdStyle                                    | 0.086     | 24.49       |
| V2RateStrategyFactory                       | 8.767     | 15.809      |
| V3RateStrategyFactory                       | 9.279     | 15.297      |
| WadRayMath                                  | 0.086     | 24.49       |
| console                                     | 0.086     | 24.49       |
| console2                                    | 0.086     | 24.49       |
| stdError                                    | 0.591     | 23.985      |
| stdJson                                     | 0.086     | 24.49       |
| stdMath                                     | 0.086     | 24.49       |
| stdStorage                                  | 0.086     | 24.49       |
| stdStorageSafe                              | 0.086     | 24.49       |

Test error

❌

No files changed, compilation skipped

Running 1 test for src/test/GovTest.t.sol:GovernanceMainnetExecutorTest
�[32m[PASS]�[0m testCreateProposal() (gas: 190002)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 1.21s

Running 2 tests for src/test/GovTest.t.sol:GovernanceTest
�[32m[PASS]�[0m testCreateProposal() (gas: 532512)
�[32m[PASS]�[0m testCreateProposalDynamicIpfsHash() (gas: 537772)
Test result: �[32mok�[0m. 2 passed; 0 failed; finished in 6.53s

Running 1 test for src/test/crosschainforwarders/MetisCrossChainForwarderTest.t.sol:MetisCrossChainForwarderTest
�[32m[PASS]�[0m testProposalE2E() (gas: 1213136)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 10.81s

Running 1 test for src/test/crosschainforwarders/OptimismCrossChainForwarderTest.t.sol:OptimismCrossChainForwarderTest
�[32m[PASS]�[0m testProposalE2E() (gas: 1196634)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 17.49s

Running 1 test for src/test/crosschainforwarders/PolygonCrossChainForwarderTest.t.sol:PolygonCrossChainForwarderTest
�[32m[PASS]�[0m testProposalE2E() (gas: 1049366)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 10.32s

Running 1 test for src/test/AaveV2ConfigEngineTest.t.sol:AaveV2ConfigEngineTest
�[32m[PASS]�[0m testV2RateStrategiesUpdates() (gas: 189361890)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 118.54s
�[2m2023-06-02T10:43:27.455049Z�[0m �[31mERROR�[0m �[2msharedbackend�[0m�[2m:�[0m Failed to send/recv `basic` �[3merr�[0m�[2m=�[0mGetAccount(0xa4b000000000000000000073657175656e636572, 
�[31m(code: -32000, message: missing trie node 66fcb55f3a5c57bf06eb2f631f7a91d309e4b3d8c1f3bc2b403cecf14700e12e (path ) <nil>, data: None)�[0m) �[3maddress�[0m�[2m=�[0m0xa4b000000000000000000073657175656e636572

src/dependencies/DefaultReserveInterestRateStrategy.sol

script/V2RateStrategyFactory.s.sol

src/v2-config-engine/AaveV2ConfigEngine.sol

- Added make scripts for deployment of v2 rate strategy factories

- Added deployed v2 rate factories

brotherlymite added 3 commits March 10, 2023 12:34

cherry-pick commit: added rates factory and base payload with tests f…

6eb1c0b

…or v2

chore: fix spacing

6fde39e

fix: missing require

64a9ad8

brotherlymite added 6 commits March 10, 2023 12:48

chore: fix folders

d98f081

docs: add diagram

8d99605

chore: add payload network contracts

22d4299

docs: update README

5858c9f

fix: missing trie node in tests

e85d95e

fix: comments

cf4f3c5

eboadom reviewed Mar 10, 2023

View reviewed changes

src/dependencies/DefaultReserveInterestRateStrategy.sol Show resolved Hide resolved

eboadom reviewed Mar 10, 2023

View reviewed changes

script/V2RateStrategyFactory.s.sol Outdated Show resolved Hide resolved

brotherlymite added 4 commits March 10, 2023 20:30

feat: add config engine instead of using rates payload base

099b1a9

fix: dependencies

3f7527c

fix: _isStandardStrategy to use codehash

94091d0

chore: add diffs for dependencies

380c359

brotherlymite marked this pull request as ready for review March 20, 2023 08:52

sakulstra reviewed May 23, 2023

View reviewed changes

script/V2RateStrategyFactory.s.sol Outdated Show resolved Hide resolved

fix: rates factory deployment and added test reports

adaa905

sakulstra approved these changes May 24, 2023

View reviewed changes

eboadom reviewed Jun 1, 2023

View reviewed changes

src/v2-config-engine/AaveV2ConfigEngine.sol Show resolved Hide resolved

eboadom added 2 commits June 1, 2023 17:01

Added comment about stateless nature of AaveV2ConfigEngine

6cd567b

fix on Makefile for v2 config engine tests

8ce2c40

eboadom approved these changes Jun 1, 2023

View reviewed changes

eboadom added 4 commits June 1, 2023 17:33

Merge branch 'master' into feat/config-engine-v2

f70a988

Added test reports of v2 rates factory

9278c11

- Fix V2RateStrategyFactory scripts

ec894ff

- Added make scripts for deployment of v2 rate strategy factories

- Added scripts on Makefile to deploy v2 config engine.

ac36e6b

- Added deployed v2 rate factories

sakulstra merged commit ccadc3c into master Jun 5, 2023

sakulstra deleted the feat/config-engine-v2 branch June 5, 2023 10:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: rates base payload and factory for v2 #68

feat: rates base payload and factory for v2 #68

brotherlymite commented Mar 10, 2023 •

edited

Loading

github-actions bot commented Mar 10, 2023 •

edited

Loading

feat: rates base payload and factory for v2 #68

feat: rates base payload and factory for v2 #68

Conversation

brotherlymite commented Mar 10, 2023 • edited Loading

github-actions bot commented Mar 10, 2023 • edited Loading

brotherlymite commented Mar 10, 2023 •

edited

Loading

github-actions bot commented Mar 10, 2023 •

edited

Loading