Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add implementation snapshots to v3 configurationSnapshots #43

Merged
merged 2 commits into from
Feb 1, 2023

Conversation

sakulstra
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

github-actions bot commented Feb 1, 2023

Foundry report

forge 0.2.0 (cd7850b 2023-02-01T00:07:50.815214322Z)
Build log
installing solc version "0.8.17"
Successfully installed solc 0.8.17
Compiling 53 files with 0.8.17
Solc 0.8.17 finished in 11.98s
Compiler run successful (with warnings)
�[33mwarning[2018]: �[0m�[33mWarning: Function state mutability can be restricted to view
 --> src/ProxyHelpers.sol:7:3:
  |
7 |   function getInitializableAdminUpgradeabilityProxyAdmin(Vm vm, address proxy)
  |   ^ (Relevant source part starts here and spans across multiple lines).

�[0m

�[33mwarning[2018]: �[0m�[33mWarning: Function state mutability can be restricted to view
  --> src/ProxyHelpers.sol:19:3:
   |
19 |   function getInitializableAdminUpgradeabilityProxyImplementation(Vm vm, address proxy)
   |   ^ (Relevant source part starts here and spans across multiple lines).

�[0m

| Contract                 | Size (kB) | Margin (kB) |
|--------------------------|-----------|-------------|
| AaveGovernanceV2         | 0.272     | 24.304      |
| AaveV2Ethereum           | 0.086     | 24.49       |
| AaveV2EthereumAssets     | 0.086     | 24.49       |
| AaveV3Polygon            | 0.086     | 24.49       |
| AaveV3PolygonAssets      | 0.086     | 24.49       |
| AaveV3PolygonMockListing | 1.976     | 22.6        |
| Address                  | 0.086     | 24.49       |
| BridgeExecutorHelpers    | 0.086     | 24.49       |
| ConfiguratorInputTypes   | 0.086     | 24.49       |
| DataTypes                | 0.086     | 24.49       |
| GenericV3ListingEngine   | 10.088    | 14.488      |
| GovHelpers               | 0.236     | 24.34       |
| MockExecutor             | 0.437     | 24.139      |
| ProxyHelpers             | 0.086     | 24.49       |
| console                  | 0.086     | 24.49       |
| console2                 | 0.086     | 24.49       |
| stdError                 | 0.591     | 23.985      |
| stdJson                  | 0.086     | 24.49       |
| stdMath                  | 0.086     | 24.49       |
| stdStorage               | 0.086     | 24.49       |
| stdStorageSafe           | 0.086     | 24.49       |
Test success 🌈
No files changed, compilation skipped

Running 1 test for src/test/GenericV3ListingEngineTest.t.sol:GenericV3ListingEngineTest
�[32m[PASS]�[0m testEngine() (gas: 7601530)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 403.42ms

Running 1 test for src/test/ProtocolV3TestBase.t.sol:ProtocolV3TestBaseTest
�[32m[PASS]�[0m testSnpashot() (gas: 2442163)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 11.35s

Running 2 tests for src/test/ProxyHelpersTest.t.sol:ProxyHelpersTest
�[32m[PASS]�[0m testAdmin() (gas: 3229)
�[32m[PASS]�[0m testImplementation() (gas: 3196)
Test result: �[32mok�[0m. 2 passed; 0 failed; finished in 1.05s

Running 1 test for src/test/ProtocolV2TestBase.t.sol:ProtocolV2TestBaseTest
�[32m[PASS]�[0m testSnpashot() (gas: 4102742)
Test result: �[32mok�[0m. 1 passed; 0 failed; finished in 44.42s

@sakulstra sakulstra merged commit e10aa98 into master Feb 1, 2023
@sakulstra sakulstra deleted the feat/impl-snapshot branch February 1, 2023 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants