feat: patch deal (reverting caller) #110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eboadom
reviewed
Jun 14, 2023
| } | ||
| } else { |
There was a problem hiding this comment.
Maybe worth it to put the forceApprove of safeERC20? https://github.com/OpenZeppelin/openzeppelin-contracts/blob/master/contracts/token/ERC20/utils/SafeERC20.sol#L76
|
Foundry report forge 0.2.0 (1a1d653 2023-06-14T00:06:40.452758373Z)Build loginstalling solc version "0.8.20"
Successfully installed solc 0.8.20
Compiling 168 files with 0.8.20
Solc 0.8.20 finished in 58.38s
Compiler run successful with warnings:
Warning (8760): This declaration has the same name as another declaration.
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:60:5:
|
60 | uint256 baseVariableBorrowRate,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: The other declaration is here:
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:92:3:
|
92 | function baseVariableBorrowRate() external view override returns (uint256) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (8760): This declaration has the same name as another declaration.
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:61:5:
|
61 | uint256 variableRateSlope1,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: The other declaration is here:
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:76:3:
|
76 | function variableRateSlope1() external view returns (uint256) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (8760): This declaration has the same name as another declaration.
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:62:5:
|
62 | uint256 variableRateSlope2,
| ^^^^^^^^^^^^^^^^^^^^^^^^^^
Note: The other declaration is here:
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:80:3:
|
80 | function variableRateSlope2() external view returns (uint256) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (8760): This declaration has the same name as another declaration.
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:63:5:
|
63 | uint256 stableRateSlope1,
| ^^^^^^^^^^^^^^^^^^^^^^^^
Note: The other declaration is here:
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:84:3:
|
84 | function stableRateSlope1() external view returns (uint256) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (8760): This declaration has the same name as another declaration.
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:64:5:
|
64 | uint256 stableRateSlope2
| ^^^^^^^^^^^^^^^^^^^^^^^^
Note: The other declaration is here:
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:88:3:
|
88 | function stableRateSlope2() external view returns (uint256) {
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (2462): Visibility for constructor is ignored. If you want the contract to be non-deployable, making it "abstract" is sufficient.
--> src/dependencies/DefaultReserveInterestRateStrategy.sol:57:3:
|
57 | constructor(
| ^ (Relevant source part starts here and spans across multiple lines).
Warning (9302): Return value of low-level calls not used.
--> src/test/crosschainforwarders/ArbitrumCrossChainForwarderTest.t.sol:139:5:
|
139 | ARBITRUM_BRIDGE_EXECUTOR.call(payload);
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
| Contract | Size (kB) | Margin (kB) |
|---------------------------------------------|-----------|-------------|
| AaveGovernanceV2 | 0.272 | 24.304 |
| AaveMisc | 0.086 | 24.49 |
| AaveV2Avalanche | 0.086 | 24.49 |
| AaveV2AvalancheAssets | 0.086 | 24.49 |
| AaveV2ConfigEngine | 3.18 | 21.396 |
| AaveV2Ethereum | 0.086 | 24.49 |
| AaveV2EthereumAMM | 0.086 | 24.49 |
| AaveV2EthereumAMMAssets | 0.086 | 24.49 |
| AaveV2EthereumArc | 0.086 | 24.49 |
| AaveV2EthereumAssets | 0.086 | 24.49 |
| AaveV2EthereumRatesUpdate | 1.512 | 23.064 |
| AaveV2Fuji | 0.086 | 24.49 |
| AaveV2FujiAssets | 0.086 | 24.49 |
| AaveV2Goerli | 0.086 | 24.49 |
| AaveV2GoerliAssets | 0.086 | 24.49 |
| AaveV2Mumbai | 0.086 | 24.49 |
| AaveV2MumbaiAssets | 0.086 | 24.49 |
| AaveV2Polygon | 0.086 | 24.49 |
| AaveV2PolygonAssets | 0.086 | 24.49 |
| AaveV3Arbitrum | 0.086 | 24.49 |
| AaveV3ArbitrumAssets | 0.086 | 24.49 |
| AaveV3ArbitrumGoerli | 0.086 | 24.49 |
| AaveV3ArbitrumGoerliAssets | 0.086 | 24.49 |
| AaveV3ArbitrumRatesUpdates070322 | 4.554 | 20.022 |
| AaveV3Avalanche | 0.086 | 24.49 |
| AaveV3AvalancheAssets | 0.086 | 24.49 |
| AaveV3AvalancheCollateralUpdate | 3.012 | 21.564 |
| AaveV3AvalancheCollateralUpdateCorrectBonus | 3.012 | 21.564 |
| AaveV3AvalancheCollateralUpdateNoChange | 3.032 | 21.544 |
| AaveV3AvalancheCollateralUpdateWrongBonus | 3.012 | 21.564 |
| AaveV3AvalancheRatesUpdates070322 | 5.119 | 19.457 |
| AaveV3ConfigEngine | 21.129 | 3.447 |
| AaveV3Ethereum | 0.086 | 24.49 |
| AaveV3EthereumAssets | 0.086 | 24.49 |
| AaveV3EthereumMockCapUpdate | 2.92 | 21.656 |
| AaveV3EthereumMockCustomListing | 3.919 | 20.657 |
| AaveV3Fantom | 0.086 | 24.49 |
| AaveV3FantomAssets | 0.086 | 24.49 |
| AaveV3FantomTestnet | 0.086 | 24.49 |
| AaveV3FantomTestnetAssets | 0.086 | 24.49 |
| AaveV3Fuji | 0.086 | 24.49 |
| AaveV3FujiAssets | 0.086 | 24.49 |
| AaveV3Goerli | 0.086 | 24.49 |
| AaveV3GoerliAssets | 0.086 | 24.49 |
| AaveV3GoerliGho | 0.086 | 24.49 |
| AaveV3GoerliGhoAssets | 0.086 | 24.49 |
| AaveV3Harmony | 0.086 | 24.49 |
| AaveV3HarmonyAssets | 0.086 | 24.49 |
| AaveV3Metis | 0.086 | 24.49 |
| AaveV3MetisAssets | 0.086 | 24.49 |
| AaveV3Mumbai | 0.086 | 24.49 |
| AaveV3MumbaiAssets | 0.086 | 24.49 |
| AaveV3Optimism | 0.086 | 24.49 |
| AaveV3OptimismAssets | 0.086 | 24.49 |
| AaveV3OptimismGoerli | 0.086 | 24.49 |
| AaveV3OptimismGoerliAssets | 0.086 | 24.49 |
| AaveV3OptimismMockRatesUpdate | 3.254 | 21.322 |
| AaveV3OptimismRatesUpdates070322 | 4.133 | 20.443 |
| AaveV3Polygon | 0.086 | 24.49 |
| AaveV3PolygonAssets | 0.086 | 24.49 |
| AaveV3PolygonBorrowUpdate | 3.005 | 21.571 |
| AaveV3PolygonMockListing | 3.731 | 20.845 |
| AaveV3PolygonPriceFeedUpdate | 2.856 | 21.72 |
| AaveV3PolygonRatesUpdates070322 | 5.858 | 18.718 |
| AaveV3ScrollAlpha | 0.086 | 24.49 |
| AaveV3ScrollAlphaAssets | 0.086 | 24.49 |
| AaveV3Sepolia | 0.086 | 24.49 |
| AaveV3SepoliaAssets | 0.086 | 24.49 |
| Address | 0.086 | 24.49 |
| AddressAliasHelper | 0.086 | 24.49 |
| CapsPlusRiskSteward | 2.607 | 21.969 |
| CapsPlusRiskStewardErrors | 0.556 | 24.02 |
| ChainIds | 0.086 | 24.49 |
| ConfiguratorInputTypes | 0.086 | 24.49 |
| CrosschainForwarderArbitrum | 2.246 | 22.33 |
| CrosschainForwarderMetis | 1.561 | 23.015 |
| CrosschainForwarderOptimism | 1.689 | 22.887 |
| CrosschainForwarderPolygon | 1.435 | 23.141 |
| DataTypes | 0.086 | 24.49 |
| DefaultReserveInterestRateStrategy | 3.469 | 21.107 |
| DeployEngineArbLib | 0.086 | 24.49 |
| DeployEngineAvaLib | 0.086 | 24.49 |
| DeployEngineEthLib | 0.086 | 24.49 |
| DeployEngineMetLib | 0.086 | 24.49 |
| DeployEngineOptLib | 0.086 | 24.49 |
| DeployEnginePolLib | 0.086 | 24.49 |
| DeployRatesFactoryArbLib | 0.086 | 24.49 |
| DeployRatesFactoryAvaLib | 0.086 | 24.49 |
| DeployRatesFactoryEthLib | 0.086 | 24.49 |
| DeployRatesFactoryLib | 0.086 | 24.49 |
| DeployRatesFactoryMetLib | 0.086 | 24.49 |
| DeployRatesFactoryOptLib | 0.086 | 24.49 |
| DeployRatesFactoryPolLib | 0.086 | 24.49 |
| DeployV2EngineAvaLib | 0.086 | 24.49 |
| DeployV2EngineEthAMMLib | 0.086 | 24.49 |
| DeployV2EngineEthLib | 0.086 | 24.49 |
| DeployV2EnginePolLib | 0.086 | 24.49 |
| DeployV2RatesFactoryAvaLib | 0.086 | 24.49 |
| DeployV2RatesFactoryEthAMMLib | 0.086 | 24.49 |
| DeployV2RatesFactoryEthLib | 0.086 | 24.49 |
| DeployV2RatesFactoryLib | 0.086 | 24.49 |
| DeployV2RatesFactoryPolLib | 0.086 | 24.49 |
| EngineFlags | 0.086 | 24.49 |
| Errors | 3.952 | 20.624 |
| FxChild | 1.039 | 23.537 |
| FxRoot | 0.811 | 23.765 |
| GovHelpers | 0.086 | 24.49 |
| MockExecutor | 0.437 | 24.139 |
| PayloadWithEmit | 0.15 | 24.426 |
| PercentageMath | 0.086 | 24.49 |
| ProxyHelpers | 0.086 | 24.49 |
| ReserveConfiguration | 0.171 | 24.405 |
| SafeERC20 | 0.086 | 24.49 |
| SafeMath | 0.086 | 24.49 |
| StdInvariant | 2.038 | 22.538 |
| StdStyle | 0.086 | 24.49 |
| V2RateStrategyFactory | 8.767 | 15.809 |
| V3RateStrategyFactory | 9.279 | 15.297 |
| WadRayMath | 0.086 | 24.49 |
| console | 0.086 | 24.49 |
| console2 | 0.086 | 24.49 |
| stdError | 0.591 | 23.985 |
| stdJson | 0.086 | 24.49 |
| stdMath | 0.086 | 24.49 |
| stdStorage | 0.086 | 24.49 |
| stdStorageSafe | 0.086 | 24.49 |Test error
|
❌
eboadom
approved these changes
Jun 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
THis patched version of deal reads the current caller, deals and reverts to the caller in case it has changed in the meantime