New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

streamline reviews #568

Open

sakulstra opened this issue Sep 3, 2024 · 1 comment

Labels

Collaborator

sakulstra commented Sep 3, 2024

@kartojal noted that sometimes reviews here are a bit slow.

The bottleneck currently is that we always manually check:

that each contract is verified on the most popular explorer of that chain
that the contracts are in fact the correct contracts
in some rare cases we even diff the contracts (or ask the pr creator to provide a diff)
for some we manually check that they are correctly configured

I think at least the first 3 points should be perfectly automatable.
No good idea yet how, but is possible for sure.

sakulstra added the enhancement label

Collaborator Author

sakulstra commented Sep 4, 2024

is now done in feat: automate verify #570 - visuals can be improved etc, but we now have a ci action reporting if added addresses are verified or not (on mainnets only atm)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment