Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style(datatrakWeb): RN-1453: Mobile survey workflow #5981

Merged
merged 38 commits into from
Nov 24, 2024
Merged

style(datatrakWeb): RN-1453: Mobile survey workflow #5981

merged 38 commits into from
Nov 24, 2024

Conversation

tcaiger
Copy link
Contributor

@tcaiger tcaiger commented Oct 24, 2024 •
edited
Loading

Issue #: RN-1453: Mobile survey workflow

Changes:

  • Survey view
  • Entity selector component
  • Survey side menu
  • Survey button menu

Screenshots:

Screenshot 2024-11-07 at 4 29 50 PM
Screenshot 2024-11-07 at 4 26 09 PM
Screenshot 2024-11-07 at 4 26 15 PM
Screenshot 2024-11-07 at 4 26 36 PM

tcaiger and others added 26 commits October 11, 2024 13:30
@tcaiger
mobile survey header
af46ec1
@tcaiger
custom icons
a02014e
@tcaiger
Update SurveyMobilePaginator.tsx
adfccb7
@tcaiger
Merge branch 'dev' into rn-1453-survey-workflow
6de4c26
@tcaiger
Merge branch 'rn-1448-responsive-dashboard' into rn-1453-survey-workflow
34860e8
@tcaiger
wip
7da7e7f
@tcaiger
fix(tupaiaWeb): RN-1512: Fix broken arithmetic visuals (#5980)
1916393 
Update utils.ts
@tcaiger
survey select page
a313a60
@tcaiger
Merge branch 'dev' into rn-1453-survey-workflow
1fc1638
@tcaiger
country selector
0f5ef43
@tcaiger
side menu
10b11cb
@hrazasalman
db(entityTypes): MAUI-4763: Add new entity types (pacmossi_insecticid…
eba85fa 
…e_test) for PacMOSSI project (#5986)

* pacmossi_insecticide_test entity type

* schema and model update
@tcaiger
copy and share
8361dd6
@tcaiger
header style
34bf7b6
@tcaiger
Update dataTables.js
10ceb6d
@tcaiger
sticky header
d662929
@tcaiger
tweak styles
e294a80
@tcaiger
style tweaks
135da5f
@tcaiger
Update ResultsList.tsx
1fc4514
@tcaiger
Merge pull request #5985 from beyondessential/release-2024-45
db9e40a 
Release 2024-45
@tcaiger
refactor list
8b2e1c0
@tcaiger
select list
6ab99ec
@tcaiger
mobile menu
d84b74f
@tcaiger
toast styles
7279b00
@tcaiger @avaek
fix(datatrak): RN-1450: Fix mobile tooltips (#5971)
04ed541 
* Update Tooltip.tsx

* set delay on BaseTooltip

---------

Co-authored-by: Andrew <[email protected]>
@tcaiger
Merge branch 'rn-1448-responsive-dashboard' into rn-1453-survey-workflow
86956ea
@tcaiger tcaiger changed the base branch from rn-1448-responsive-dashboard to rn-1452-survey-select November 7, 2024 01:54
@tcaiger tcaiger changed the title RN-1453: Mobile survey workflow style(datatrakWeb): RN-1453: Mobile survey workflow Nov 7, 2024
jaskfla
jaskfla requested changes Nov 8, 2024
View reviewed changes
Copy link
Contributor

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat stuff! My only ✌️real✌️ request is about the accessibility issue in <SurveyDisplayName>

The rest are just suggested minor touch-ups, so could easily be dropped depending on your workload 🙂

packages/datatrak-web/src/components/CancelConfirmModal.tsx Outdated Show resolved Hide resolved
packages/datatrak-web/src/components/Icons/ArrowLeftIcon.tsx Outdated Show resolved Hide resolved
packages/datatrak-web/src/features/EntitySelector/SearchField.tsx Show resolved Hide resolved
packages/datatrak-web/src/features/Survey/Components/CopySurveyUrlButton.tsx Outdated Show resolved Hide resolved
packages/datatrak-web/src/features/Survey/Components/SurveyDispalyName.tsx Outdated Show resolved Hide resolved
packages/datatrak-web/src/features/Survey/Components/SurveyDispalyName.tsx Outdated Show resolved Hide resolved
packages/datatrak-web/src/features/Survey/Components/SurveySideMenu/SurveySideMenu.tsx Outdated Show resolved Hide resolved
packages/datatrak-web/src/theme/theme.ts Outdated Show resolved Hide resolved
packages/datatrak-web/src/utils/toast.ts Outdated Show resolved Hide resolved
packages/datatrak-web/src/utils/toast.ts Outdated Show resolved Hide resolved
tcaiger and others added 6 commits November 12, 2024 20:35
@tcaiger
pr suggestions
e25ccc8
@tcaiger
Update CancelConfirmModal.tsx
2c91fdd
@tcaiger
tweak(datatrak): RN-1451: DataTrak request country access form (#6000)
5438c07 
Update RequestCountryAccessForm.tsx
@alexd-bes @avaek
tweak(adminPanel): RN-1419: Don't delete survey screens and component…
ec216e2 
…s on import unless they have changed (#5885)

* Working check

* Handle object equality with stringify

* Fix object equality check

* Remove console log

---------

Co-authored-by: Andrew <[email protected]>
@tcaiger
Merge branch 'dev' into rn-1453-survey-workflow
cfda04f
@tcaiger
Update SurveyDisplayName.tsx
a52bb35
@tcaiger tcaiger requested a review from jaskfla November 22, 2024 03:41
jaskfla
jaskfla approved these changes Nov 22, 2024
View reviewed changes
Copy link
Contributor

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉🙏

@tcaiger tcaiger merged commit a3591e6 into rn-1452-survey-select Nov 24, 2024
41 of 44 checks passed
@tcaiger tcaiger deleted the rn-1453-survey-workflow branch November 24, 2024 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaskfla jaskfla jaskfla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tcaiger @jaskfla @hrazasalman @alexd-bes