Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(adminPanel): RN-1496: Fix admin panel download file types #5948

Merged
merged 3 commits into from
Nov 3, 2024

Conversation

tcaiger
Copy link
Contributor

@tcaiger tcaiger commented Oct 7, 2024

Issue #: fix(adminPanel): RN-1496: Fix admin panel download file types

Changes:

  • Explicitly set file types in export config for each page
  • Note that for survey response downloads the file name is generated on the server and includes an explicit file type

@tcaiger tcaiger changed the base branch from dev to rn-1496-roll-back October 7, 2024 21:11
Copy link
Contributor

@jaskfla jaskfla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙏

Comment on lines 133 to 135
const { dhisInstanceCode = 'regional' } = currentRecord
? currentRecord['data_group.config'] ?? {}
? (currentRecord['data_group.config'] ?? {})
: {};
Copy link
Contributor

@jaskfla jaskfla Oct 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be tempted to simplify this to…

const { dhisInstanceCode = 'regional' } = currentRecord?.['data_group.config'] ?? {};

…or…

const  dhisInstanceCode = currentRecord?.['data_group.config'].dhisInstanceCode ?? 'regional';

…but I presume this was just a change by Prettier, so also happy for you to call it out-of-scope for this PR

Base automatically changed from rn-1496-roll-back to dev October 8, 2024 02:18
@tcaiger tcaiger merged commit 4c9f2a3 into dev Nov 3, 2024
45 checks passed
@tcaiger tcaiger deleted the rn-1496-fix-download-file-types branch November 3, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants