FQS links open in new tab #2661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tcaiger
approved these changes
Jun 13, 2021
tcaiger
reviewed
Jun 13, 2021
| @@ -105,7 +105,7 @@ export const TwoColumnPageView = ({ content }) => { | |||
| </CardHeader> | |||
| <CardBody> | |||
| {links.map(({ name, link }) => ( | |||
| <Link key={name} href={link}> | |||
| <Link key={name} href={link} target="_blank" rel="noopener"> | |||
There was a problem hiding this comment.
Suggested change
| <Link key={name} href={link} target="_blank" rel="noopener"> | |
| <Link key={name} href={link} target="_blank"> |
I don't think we need to add rel any more.
https://developer.mozilla.org/en-US/docs/Web/HTML/Link_types/noopener
Setting target="_blank" on elements now implicitly provides the same rel behavior as setting rel="noopener"
There was a problem hiding this comment.
Ah cool! I guess there's a bit of a risk someone might be using e.g. Chrome from last year, but considering we know the links that are being opened I'm happy to remove it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just a suggestion - @enunan do you think the FQS links should open in a new tab or just replace the LESMIS page and stay on the same tab?