feat(medication): EPI-1093: Add medication administration schedule to prescription form #7269
+458
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1099-updates-to-frequency-logic-and-configuration
huytranbes
reviewed
Feb 26, 2025
| { startTime: '16:00', endTime: '18:00' }, | ||
| { startTime: '18:00', endTime: '20:00', mealTime: 'dinner' }, | ||
| { startTime: '20:00', endTime: '22:00' }, | ||
| { startTime: '22:00', endTime: '24:00', mealTime: 'night' }, |
There was a problem hiding this comment.
mealTime isn't appropriate for 'Night'. Maybe use periodLabel
huytranbes
reviewed
Feb 26, 2025
| const handleResetToDefault = () => { | ||
| if ( | ||
| values.frequency === ADMINISTRATION_FREQUENCIES.AS_DIRECTED || | ||
| values.frequency === ADMINISTRATION_FREQUENCIES.IMMEDIATELY |
There was a problem hiding this comment.
Can you put this in a constant to avoid duplication. E.g
export const NON_REPEATING_FREQUENCIES = [ADMINISTRATION_FREQUENCIES.AS_DIRECTED, ADMINISTRATION_FREQUENCIES.IMMEDIATELY]
huytranbes
reviewed
Feb 26, 2025
| borderRadius="3px" | ||
| width="187px" | ||
| height="fit-content" | ||
| border={`1px solid ${checked ? Colors.primary : Colors.outline}`} |
There was a problem hiding this comment.
Optional: Please use styled-component for better readability
huytranbes
approved these changes
Feb 26, 2025
There was a problem hiding this comment.
Did you put the wrong task? It should be https://linear.app/bes/issue/EPI-1093/add-medication-administration-schedule-to-prescription-form
Approved but please fix the above issues before merging
khoi-bes
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Add a brief description of the changes in this PR to help give the reviewer context.
Deploys
Remember to...