Integration Test #144
Draft
Integration Test #144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
love it! would be great to disable logging when testing as that's unlikely to ever be useful test output |
|
Would you disable all logging? I thought warnings may be useful to test. For example, when a |
|
good call. limiting to warning and up by default at least would be best; also would be nice to find a way to kill colour usage for tests so it doesn't have all the [33m etc escapes |
passcod
force-pushed
the
main
branch
2 times, most recently
from
381ecc0
to
d4b4a21
Compare
It only tests --dry-run.
It also responds to env var BESTOOL_TIMELESS for removing timestamps. This makes it easier to configure multiple tests via env vars.
Also delete logic to remove time from logs as it's not longer needed. Leave the logic to print logs to stderr with RUST_LOG mode intact.
Add time to the template to test mocked time
… deleted before bash runs
rail-rain
force-pushed
the
test/kam-294-bestool-integration-tests
branch
from
cd009b2
to
3151539
Compare
passcod
approved these changes
Nov 27, 2024
|
|
||
| let handle_res = init_db().and_then(run_db); | ||
|
|
||
| if matches!(handle_res, Err(_)) { |
There was a problem hiding this comment.
Suggested change
| if matches!(handle_res, Err(_)) { | |
| if handle_res.is_err() { |
passcod
reviewed
Nov 29, 2024
| @@ -110,3 +117,73 @@ fn stop_db(temp_dir: TempDir) -> Result<()> { | |||
|
|
|||
| Ok(()) | |||
| } | |||
|
|
|||
| pub fn find_postgres_bin(name: &str) -> Result<OsString> { | |||
There was a problem hiding this comment.
is this copied from the lib? can we expose that and re-use instead?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Right now, it's just a rough demo of
trycmdwith one test case for Tamanu Alerts.