Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple initialization of synced and unsynced luarules entrypoints #1900

Open
badosu opened this issue Jan 15, 2025 · 0 comments
Open

Decouple initialization of synced and unsynced luarules entrypoints #1900

badosu opened this issue Jan 15, 2025 · 0 comments
Labels
enhancement New feature or request

Comments

@badosu
Copy link
Collaborator

badosu commented Jan 15, 2025

Currently synced and unsynced luarules entrypoints are coupled in a way that an empty or no existent entrypoint for one kills the lua environment for both, see: https://github.com/beyond-all-reason/spring/blob/0daacfd/rts/Lua/LuaHandleSynced.cpp#L2218-L2218 , https://github.com/beyond-all-reason/spring/blob/BAR105/rts/Lua/LuaHandleSynced.h#L229-L232

A game should be able to have one without necessarily having the other. While it's unrealistic that in the longer term a game does not have both, this is relevant when adding pieces at the bootstrapping phase of a game.

@badosu badosu added good first issue Good for newcomers enhancement New feature or request and removed good first issue Good for newcomers labels Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant