Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

thread panics: regex parse error (\/\/|\/\*|\*\/) #9690

Closed
Foobin opened this issue Sep 4, 2023 · 1 comment
Closed

thread panics: regex parse error (\/\/|\/\*|\*\/) #9690

Foobin opened this issue Sep 4, 2023 · 1 comment
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled

Comments

@Foobin
Copy link

Foobin commented Sep 4, 2023

Bevy version

0.11.2

[Optional] Relevant system information

  • cargo 1.72.0 (103a7ff2e 2023-08-15)
  • Ubuntu 22.04.3 LTS

What you did

After updating from 0.10 to 0.11.2 bevy no longer works.
The following is enough to cause a crash:

use bevy::{prelude::App, DefaultPlugins};

fn main() {
    App::new()
        .add_plugins(DefaultPlugins)
        .run();
}

What went wrong

Trace 


thread 'main' panicked at 'called `Result::unwrap()` on an `Err` value: Syntax(
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
regex parse error:
    (\/\/|\/\*|\*\/)
     ^^
error: unrecognized escape sequence
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
)', /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga_oil-0.8.2/src/compose/comment_strip_iter.rs:6:67
stack backtrace:
   0: rust_begin_unwind
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:593:5
   1: core::panicking::panic_fmt
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panicking.rs:67:14
   2: core::result::unwrap_failed
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/result.rs:1651:5
   3: core::result::Result<T,E>::unwrap
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/result.rs:1076:23
   4: naga_oil::compose::comment_strip_iter::RE_COMMENT::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga_oil-0.8.2/src/compose/comment_strip_iter.rs:6:35
   5: core::ops::function::FnOnce::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:250:5
   6: core::ops::function::FnOnce::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:250:5
   7: once_cell::sync::Lazy<T,F>::force::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/lib.rs:1278:28
   8: once_cell::sync::OnceCell<T>::get_or_init::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/lib.rs:1088:57
   9: once_cell::imp::OnceCell<T>::initialize::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/imp_std.rs:82:23
  10: core::ops::function::impls::<impl core::ops::function::FnMut<A> for &mut F>::call_mut
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:294:13
  11: once_cell::imp::initialize_or_wait
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/imp_std.rs:206:20
  12: once_cell::imp::OnceCell<T>::initialize
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/imp_std.rs:78:9
  13: once_cell::sync::OnceCell<T>::get_or_try_init
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/lib.rs:1129:13
  14: once_cell::sync::OnceCell<T>::get_or_init
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/lib.rs:1088:19
  15: once_cell::sync::Lazy<T,F>::force
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/lib.rs:1277:13
  16: <once_cell::sync::Lazy<T,F> as core::ops::deref::Deref>::deref
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/once_cell-1.17.1/src/lib.rs:1338:13
  17: <naga_oil::compose::comment_strip_iter::CommentReplaceIter as core::iter::traits::iterator::Iterator>::next
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga_oil-0.8.2/src/compose/comment_strip_iter.rs:18:27
  18: naga_oil::compose::preprocess::Preprocessor::get_preprocessor_metadata
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga_oil-0.8.2/src/compose/preprocess.rs:400:21
  19: naga_oil::compose::get_preprocessor_data
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/naga_oil-0.8.2/src/compose/mod.rs:1889:61
  20: bevy_render::render_resource::shader::Shader::preprocess
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_render-0.11.2/src/render_resource/shader.rs:42:41
  21: bevy_render::render_resource::shader::Shader::from_wgsl
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_render-0.11.2/src/render_resource/shader.rs:71:38
  22: <bevy_render::view::window::screenshot::ScreenshotPlugin as bevy_app::plugin::Plugin>::build
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_render-0.11.2/src/view/window/screenshot.rs:132:9
  23: bevy_app::app::App::add_boxed_plugin::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:713:55
  24: core::ops::function::FnOnce::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:250:5
  25: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic/unwind_safe.rs:271:9
  26: std::panicking::try::do_call
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:500:40
  27: __rust_try
  28: std::panicking::try
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:464:19
  29: std::panic::catch_unwind
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panic.rs:142:14
  30: bevy_app::app::App::add_boxed_plugin
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:713:22
  31: <P as bevy_app::plugin::sealed::Plugins<bevy_app::plugin::sealed::PluginMarker>>::add_to_app
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/plugin.rs:94:17
  32: bevy_app::app::App::add_plugins
             at /home/otoom__rust_trymeey/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:803:9
  33: <bevy_render::view::window::WindowRenderPlugin as bevy_app::plugin::Plugin>::build
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_render-0.11.2/src/view/window.rs:37:9
  34: bevy_app::app::App::add_boxed_plugin::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:713:55
  35: core::ops::function::FnOnce::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:250:5
  36: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic/unwind_safe.rs:271:9
  37: std::panicking::try::do_call
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:500:40
  38: __rust_try
  39: std::panicking::try
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:464:19
  40: std::panic::catch_unwind
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panic.rs:142:14
  41: bevy_app::app::App::add_boxed_plugin
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:713:22
  42: <P as bevy_app::plugin::sealed::Plugins<bevy_app::plugin::sealed::PluginMarker>>::add_to_app
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/plugin.rs:94:17
  43: <(S0,S1,S2,S3,S4,S5,S6) as bevy_app::plugin::sealed::Plugins<(bevy_app::plugin::sealed::PluginsTupleMarker,P0,P1,P2,P3,P4,P5,P6)>>::add_to_app
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/plugin.rs:118:23
  44: bevy_app::app::App::add_plugins
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:803:9
  45: <bevy_render::RenderPlugin as bevy_app::plugin::Plugin>::build
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_render-0.11.2/src/lib.rs:331:9
  46: bevy_app::app::App::add_boxed_plugin::{{closure}}
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:713:55
  47: core::ops::function::FnOnce::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:250:5
  48: <core::panic::unwind_safe::AssertUnwindSafe<F> as core::ops::function::FnOnce<()>>::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/panic/unwind_safe.rs:271:9
  49: std::panicking::try::do_call
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:500:40
  50: __rust_try
  51: std::panicking::try
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panicking.rs:464:19
  52: std::panic::catch_unwind
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/std/src/panic.rs:142:14
  53: bevy_app::app::App::add_boxed_plugin
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:713:22
  54: bevy_app::plugin_group::PluginGroupBuilder::finish
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/plugin_group.rs:181:25
  55: <P as bevy_app::plugin::sealed::Plugins<bevy_app::plugin::sealed::PluginGroupMarker>>::add_to_app
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/plugin.rs:105:13
  56: bevy_app::app::App::add_plugins
             at /home/me/.cargo/registry/src/index.crates.io-6f17d22bba15001f/bevy_app-0.11.2/src/app.rs:803:9
  57: rzero::main
             at ./src/main.rs:4:5
  58: core::ops::function::FnOnce::call_once
             at /rustc/5680fa18feaa87f3ff04063800aec256c3d4b4be/library/core/src/ops/function.rs:250:5

Additional information

Version 0.10 worked fine. I've also tried completely removing the build directory to do a fresh build but this did not work either.
@Foobin Foobin added C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled labels Sep 4, 2023
@Foobin
Copy link
Author

Foobin commented Sep 4, 2023

It looks like this is a known problem in naga_oil , closing for now.

@Foobin Foobin closed this as completed Sep 4, 2023
@alice-i-cecile alice-i-cecile mentioned this issue Sep 4, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-Bug An unexpected or incorrect behavior S-Needs-Triage This issue needs to be labelled
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Foobin