Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow passing --jobs to ci to prevent OOM on home machines #16051

Open
hukasu opened this issue Oct 22, 2024 · 2 comments · May be fixed by #16145
Open

Allow passing --jobs to ci to prevent OOM on home machines #16051

hukasu opened this issue Oct 22, 2024 · 2 comments · May be fixed by #16145
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!

Comments

@hukasu
Copy link

hukasu commented Oct 22, 2024 •
edited
Loading

What problem does this solve or what need does it fill?

Home machines does not have the same amount as the machines that run CI on GitHub, or maybe it is because the machines that run CI on GitHub have a small amount of CPUs, so running cargo run -p ci -- doc may cause OOM.

What solution would you like?

Allow passing --jobs into ci (cargo run -p ci -- doc --jobs n) to decrease parallelism and prevent OOM.
@hukasu hukasu added C-Feature A new feature, making something new possible S-Needs-Triage This issue needs to be labelled labels Oct 22, 2024
@hukasu
Copy link
Author

hukasu commented Oct 22, 2024

Using RUST_BUILD_JOBS=4 cargo run -p ci -- doc works for limiting the number of build jobs, but now i have an issue with the number of test jobs running in parallel, which is controlled by --test-threads on the test harness (cargo test -- --test-threads=n), which would also be nice to include

@hukasu
Copy link
Author

hukasu commented Oct 22, 2024

related #12207

@BenjaminBrienen BenjaminBrienen added A-Build-System Related to build systems or continuous integration S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it! D-Straightforward Simple bug fixes and API improvements, docs, test and examples and removed S-Needs-Triage This issue needs to be labelled labels Oct 28, 2024
@BenjaminBrienen BenjaminBrienen linked a pull request Oct 28, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
A-Build-System Related to build systems or continuous integration C-Feature A new feature, making something new possible D-Straightforward Simple bug fixes and API improvements, docs, test and examples S-Ready-For-Implementation This issue is ready for an implementation PR. Go for it!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add argument to ci for test threads and build jobs BenjaminBrienen/bevy
2 participants
@hukasu @BenjaminBrienen