Skip to content

Commit

Permalink
add timeouts to CI jobs (#7453)
Browse files Browse the repository at this point in the history
# Objective

- Avoid hitting the 6 hours default timeout
- Waiting for 6 hours for a job to fail is wasteful and slow down CI for other PRs

## Solution

- Put shorter timeouts on all jobs
  • Loading branch information
mockersf committed Feb 1, 2023
1 parent f3b8ff6 commit 69fc8c6
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
9 changes: 9 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,7 @@ jobs:
matrix:
os: [windows-latest, ubuntu-latest, macos-latest]
runs-on: ${{ matrix.os }}
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v3
Expand All @@ -41,6 +42,7 @@ jobs:

ci:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v3
Expand Down Expand Up @@ -96,6 +98,7 @@ jobs:

check-compiles:
runs-on: ubuntu-latest
timeout-minutes: 30
needs: ci
steps:
- uses: actions/checkout@v3
Expand All @@ -122,6 +125,7 @@ jobs:

build-wasm:
runs-on: ubuntu-latest
timeout-minutes: 30
needs: build
steps:
- uses: actions/checkout@v3
Expand All @@ -142,6 +146,7 @@ jobs:

markdownlint:
runs-on: ubuntu-latest
timeout-minutes: 30
needs: check-missing-examples-in-docs
if: always()
steps:
Expand Down Expand Up @@ -216,6 +221,7 @@ jobs:

check-doc:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v2
Expand Down Expand Up @@ -247,6 +253,7 @@ jobs:

check-missing-examples-in-docs:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- name: check for missing metadata
Expand Down Expand Up @@ -279,6 +286,7 @@ jobs:

check-unused-dependencies:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3
- uses: actions/cache@v3
Expand All @@ -302,6 +310,7 @@ jobs:

msrv:
runs-on: ubuntu-latest
timeout-minutes: 30
needs: build
steps:
- uses: actions/checkout@v3
Expand Down
3 changes: 3 additions & 0 deletions .github/workflows/validation-jobs.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ env:
jobs:
build-and-install-on-iOS:
runs-on: macos-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3

Expand All @@ -32,6 +33,7 @@ jobs:

build-android:
runs-on: ubuntu-latest
timeout-minutes: 30
steps:
- uses: actions/checkout@v3

Expand Down Expand Up @@ -147,6 +149,7 @@ jobs:
path: .github/start-wasm-example/screenshot-*.png

build-without-default-features:
timeout-minutes: 30
strategy:
matrix:
crate: [bevy_ecs, bevy_reflect, bevy]
Expand Down

0 comments on commit 69fc8c6

Please sign in to comment.