Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Placeholder Color for Better Readability #1

Open
SallesCosta opened this issue Oct 7, 2024 · 6 comments
Open

Change Placeholder Color for Better Readability #1

SallesCosta opened this issue Oct 7, 2024 · 6 comments
Labels
good first issue Good for newcomers

Comments

@SallesCosta
Copy link

I ran a :Lazy update i my neovim config and noticed that the placeholder color (#FFFF00)
is being used as the background for text with the color color300 (#A9A9A9). Since both colors are light, it is difficult to read the text. Please see the attached image for reference. I suggest changing the placeholder color to improve readability.

Screenshot 2024-10-07 at 16 47 17

@SallesCosta
Copy link
Author

Suggestion:

  • If placeholder has an other usage and it is good, one more token color could be added.
    or
  • Replace the yellow color from placeholder.

Some suggestions. In this example, the text color is #A9A9A9.
Screenshot 2024-10-07 at 17 50 11

@vmarcosp vmarcosp added the good first issue Good for newcomers label Oct 8, 2024
@vmarcosp
Copy link
Contributor

vmarcosp commented Oct 8, 2024

To be honest, the placeholder color was just a way to keep track of undefined tokens, as yellow isn't used anywhere else in the theme. I’ll review this and define a new color for such cases. Thanks for bringing this to my attention.

@vmarcosp
Copy link
Contributor

vmarcosp commented Oct 8, 2024

@SallesCosta I've just a released a fix, could you please test and confirm that its working as expected?

@SallesCosta
Copy link
Author

@vmarcosp I just updated my version of better-vim and the yellow background remains. I have the v 0.0.2
Am I missing something?
thanks

Screenshot 2024-11-11 at 09 57 38

Screenshot 2024-11-11 at 10 05 02

@vmarcosp
Copy link
Contributor

It seems an issue with another highlight group. Could you please send me the content of the file from your screenshot?

@SallesCosta
Copy link
Author

The content is just a Dialog from ShadCn-ui. I did the Signature Documentation. leader + l + s in default better-vim settings.
Screenshot 2024-11-13 at 09 51 46
@vmarcosp

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants