Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MarketChangeMessage and OrderChangeMessage Id and Op not overriding Change message properties #18

Open
WookerEmUp opened this issue Jan 19, 2021 · 1 comment

Comments

@WookerEmUp
Copy link

I'm not sure if this is intended behaviour, the way swagger creates definitions or an oversight, but is there a reason for this.

Derived classes Betfair.ESASwagger.Model.MarketChangeMessage and Betfair.ESASwagger.Model.OrderChangeMessage hide both Id and Op properties from Betfair.ESASwagger.Model.ChangeMessage. With the demo code it doesn't cause any issue, however extending the behaviour of the code does through some unintended behaviour.

Thanks
Wook

@davezeetone
Copy link

MarketSubscription in RequestResponseProcessor overrides custom id with next default id. looks like it is just to prevent conflicting ids and we will have to sort it out ourselves

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants