Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for vendor prefixes #15

Open
AlexOuttaspace opened this issue Apr 24, 2019 · 2 comments
Open

Add support for vendor prefixes #15

AlexOuttaspace opened this issue Apr 24, 2019 · 2 comments

Comments

@AlexOuttaspace
Copy link

AlexOuttaspace commented Apr 24, 2019

React uses PascalCase to handle vendor prefixed inline styles. This means that if in your project you encountered a situation, where you need to add something like -webkit-text-stroke-color, this library wont be able to handle it and as a result JSX element will receive this css property with camelCased key webkitTextStrokeColor.

I would like to make a pull request that addresses this issue by slightly changing the behaviour of functions used to change casing of css properies' keys.

I have already forked this project and made some changes

@betancourtl
Copy link
Owner

Hey thx for submitting the Pull Request. I definitely missed that case. I'm willing to merge this as long as there are some unit tests and all the functionality stays the same. I will take a look at this sometime tonight and if everything seems good I can merge.

@AlexOuttaspace
Copy link
Author

@webdeveloperpr I've updated the code and added some tests. I also tested this in my own project and everything seems to be working fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants