Add fallback method for HttpClient.Send on unsupported platforms #316
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dev v7.1.1 beta
Addressed an issue related to the using statement that was trying to send a disposed HttpRequestMessage in the catch block
|
Do you have a sample repository that I can use to test this? I am wondering if the stream works with your changes. 🤔 |
You can find a sample here: https://github.com/Almis90/OpenAI.HttpClientIssue To run it you will need to add your API key in the MauiProgram.cs After you click the send button you will see the exception in the application output. |
|
Thanks a lot, I will take a look. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this commit, I have introduced error handling to manage the
PlatformNotSupportedExceptionthat arises when calling HttpClient.Send in the PostAsStreamAsync method.This exception occurs because of the HttpClient.Send method is not supported on certain platforms (in my case I was testing on MAUI, Mac Platform). To manage this, I have added a try-catch block to catch the PlatformNotSupportedException and then fall back to the SendRequestPreNet6 method, which uses HttpClient.SendAsync.