Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-implement craft_name within output file names (as option?) #3636

Closed
pitts-mo opened this issue Nov 17, 2023 · 0 comments · Fixed by #3637
Closed

re-implement craft_name within output file names (as option?) #3636

pitts-mo opened this issue Nov 17, 2023 · 0 comments · Fixed by #3637

Comments

@pitts-mo
Copy link

Is your feature request related to a problem? Please describe

I have needed to maintain multiple different configurations on the same FC target.

In this use case having the craft_name within the Diff/Dump/Backup file names has been more helpful than target name when finding the correct configuration file(s) .

Describe the solution you'd like

Append "_craft_name" within output file names when not empty.

eg:
BTFL_cli_backup_20231117_123456_BETAFLIGHTF4**_craft_name**.txt

Describe alternatives you've considered

Because craft_name is contained within the file contents (if set) I can not think of any good reason this should not be the default option. However, if there is a good reason to set craft_name within config and not include craft_name in the file name maybe we should add a user option to the configurator?

Other information

For now I have been appending craft_name manually in order to save time and prevent error when searching the file contents to find/re-load the correct config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants