Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix GitHub Actions for patches #40

Closed
ESKYoung opened this issue Jul 15, 2021 · 0 comments · Fixed by #41
Closed

Fix GitHub Actions for patches #40

ESKYoung opened this issue Jul 15, 2021 · 0 comments · Fixed by #41
Labels
bug Something isn't working

Comments

@ESKYoung
Copy link
Collaborator

The govcookiecutter template build GitHub Action tries to mimic how a user would build the template. It uses GitHub environment variables to define the GitHub repository that cookiecutter should access.

However, if a PR is not raised from within ukgovdatascience, which will be the case for external contributors who raise patches, this Action fails, as the GITHUB_REPOSITORY variable refers to ukgovdatascience/govcookiecutter not the fork itself. This behaviour is seen in PR #39.

Also, the govcookiecutter build Action does not run for patches, so this needs to be triggered for PRs as well!

@ESKYoung ESKYoung added the bug Something isn't working label Jul 15, 2021
@ESKYoung ESKYoung linked a pull request Jul 19, 2021 that will close this issue
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant