Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Ability to set ModuleInfo.Version ? #138

Closed
HUGIN-NSJ opened this issue Apr 29, 2020 · 4 comments
Closed

Feature: Ability to set ModuleInfo.Version ? #138

HUGIN-NSJ opened this issue Apr 29, 2020 · 4 comments

Comments

@HUGIN-NSJ
Copy link

There is a command line option: '[javac|jar] --module-version XXX' which specifies ModuleInfo.Version.
It would be really nice to have an option for setting this version for any solution.

@siordache
Copy link
Member

The badass-jlink-plugin is not involved in building the main application module. This job is performed by the gradle-modules-plugin (which is also used under the hood by the org.openjfx.javafxplugin). There is an issue requesting to add support for setting the module version to the gradle-modules-plugin.

However, the badass-jlink-plugin could add support for setting the version of the merged module.

@HUGIN-NSJ
Copy link
Author

Hi siordache!
Thanks for clarifying this. I think the support for setting the version of the merged module would add great value. At least, it's a highly desired feature from my side.

@siordache
Copy link
Member

In version 2.19.0, the plugin uses the project version or the version of the main module as default value for the version of the merged module. You can specify a custom version for the merged module as described in the documentation:

jlink {
    mergedModule {
        version = '1.2.3'
        ...
    }
    ...

I also submitted a pull request to the gradle-modules-plugin to allow setting the module version of the main module.

@HUGIN-NSJ
Copy link
Author

Thanks for your assistance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants