Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: modify flags define #457

Merged
merged 1 commit into from
Sep 15, 2022
Merged

Conversation

Doozers
Copy link
Collaborator

@Doozers Doozers commented Sep 14, 2022

relate to #456
Can't use exactly the same code style cause berty/yolo is using ffcli/v2 instead of ffcli/v3 for berty/berty

@auto-add-label auto-add-label bot added the enhancement New feature or request label Sep 14, 2022
@trafico-bot trafico-bot bot added the 🔍 Ready for Review Pull Request is not reviewed yet label Sep 14, 2022
@Doozers Doozers force-pushed the dev/isma/refacto-flags branch from 5daa6d0 to 87e3f9b Compare September 14, 2022 13:51
@Doozers Doozers changed the title feat: split commands declarations feat: modify flags define Sep 14, 2022
@Doozers Doozers marked this pull request as ready for review September 14, 2022 15:46
@Doozers Doozers requested a review from moul as a code owner September 14, 2022 15:46
@Doozers Doozers linked an issue Sep 15, 2022 that may be closed by this pull request
@trafico-bot trafico-bot bot added ✅ Approved Pull Request has been approved and can be merged and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Sep 15, 2022
@moul moul merged commit 0ff5fde into berty:master Sep 15, 2022
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed ✅ Approved Pull Request has been approved and can be merged labels Sep 15, 2022
@github-actions
Copy link

🎉 This PR is included in version 2.109.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@Doozers Doozers deleted the dev/isma/refacto-flags branch September 15, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use berty/berty similar coding style to define flags in the go main
2 participants