fix: lint #438
Merged
fix: lint #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as outdated.
This comment was marked as outdated.
Signed-off-by: ismael FALL <[email protected]>
Doozers
force-pushed
the
dev/isma/fix-golangci
branch
from
751d8df to
648f115
Compare
Signed-off-by: ismael FALL <[email protected]>
Signed-off-by: ismael FALL <[email protected]>
|
I think you managed to find the solution :) Ready for the final review? |
|
@moul Yes I finally found it but needed to "nolint" an import cause of the old version of the protoc gen. |
moul
reviewed
Sep 7, 2022
moul
approved these changes
Sep 7, 2022
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
|
🎉 This PR is included in version 2.103.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.