Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pull to refresh #407

Merged
merged 1 commit into from
Oct 14, 2020
Merged

fix: pull to refresh #407

merged 1 commit into from
Oct 14, 2020

Conversation

ekelen
Copy link
Collaborator

@ekelen ekelen commented Oct 13, 2020

Swipe down on iOS/Android to refresh. The animation isn't instantaneous but the functionality seems worth keeping.

Also hides empty footer on mobile (it's ugly on mobile browsers that allow drag at bottom of view).

@ekelen ekelen added the front label Oct 13, 2020
@ekelen ekelen self-assigned this Oct 13, 2020
@auto-add-label auto-add-label bot added the WIP label Oct 13, 2020
@trafico-bot trafico-bot bot added the 🚧 WIP Still work-in-progress, please don't review and don't merge label Oct 13, 2020
@ekelen ekelen force-pushed the fix/pull-to-refresh branch from 429edf4 to 12fa0f4 Compare October 13, 2020 18:05
@ekelen ekelen changed the title WIP: fix: pull to refresh fix: pull to refresh Oct 14, 2020
@auto-add-label auto-add-label bot added bug Something isn't working and removed WIP labels Oct 14, 2020
@trafico-bot trafico-bot bot added 🔍 Ready for Review Pull Request is not reviewed yet and removed 🚧 WIP Still work-in-progress, please don't review and don't merge labels Oct 14, 2020
fix: get rid of weird bounce in pull-to-refresh

save displayFeed in local storage to persist between drag refresh

fix: qr modal sizing

Signed-off-by: Elizabeth Kelen <[email protected]>
@ekelen ekelen force-pushed the fix/pull-to-refresh branch from 12fa0f4 to 3e6893a Compare October 14, 2020 15:12
@ekelen ekelen merged commit e35f0cb into master Oct 14, 2020
@ekelen ekelen deleted the fix/pull-to-refresh branch October 14, 2020 15:27
@trafico-bot trafico-bot bot added ✨ Merged Pull Request has been merged successfully and removed 🔍 Ready for Review Pull Request is not reviewed yet labels Oct 14, 2020
@github-actions
Copy link

🎉 This PR is included in version 2.96.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working front ✨ Merged Pull Request has been merged successfully released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant