Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for some issues #183

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Fixes for some issues #183

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
b4a6036
Fix printing of discretevectorparam with length 0 default
Jun 25, 2017
a72a17f
make 'tunable' uniform
Jun 25, 2017
dcdb6f9
Adding makeCharacterLearnerParam
Jun 25, 2017
50b17a2
roxygenize
Jun 25, 2017
8096d71
Forgot name change when copy-pasting
Jun 25, 2017
b98b927
Use isTRUE instead of is.na && ...
jakob-r Jun 26, 2017
3b26d9b
Use vcapply instead of sapply
jakob-r Jun 26, 2017
c19ca1f
typo
jakob-r Jun 26, 2017
e94c9ee
add tests, fix name to makeCharacterVectorLearnerParam
jakob-r Jun 26, 2017
a3d2c6a
fix test, NAMESPACE
jakob-r Jun 26, 2017
6e75590
Print 'list()' as default value for empty list
Jul 25, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion R/convertDiscrete.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,6 +65,6 @@ discreteValueToName = function(par, x) {
if (par$type == "discrete") {
ns[getIndex(par$values, x)]
} else if (par$type == "discretevector") {
sapply(x, function(x) ns[getIndex(x, values = par$values)])
vcapply(x, function(app x) ns[getIndex(x, values = par$values)])
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The nice thing about sapply is that it gives list() in case of length(x) == 0, which would match quite nicely with the actual default being list(). When the related BBmisc issue gets fixed, this will result in the most natural printout. vcapply will give character(0) when x is list(), which is a deviation from the behaviour of the other "vector" types (which always show logical(0), numeric(0) etc. depending on their type).

Not going to say much about the syntax error here.

Copy link
Member

@jakob-r jakob-r Jun 26, 2017 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about the typo. But in the documentation we say that the output is a character vector.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, I didn't consider the other points from which discreteValueToName gets called. I'd still say the printout of a discreteVectorLearnerParam with default list() shouldn't have character(0) in it.

}
}