Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be ready for serialport-rs v2.0 #2

Closed
3 of 4 tasks
berkowski opened this issue Jul 30, 2017 · 9 comments
Closed
3 of 4 tasks

Be ready for serialport-rs v2.0 #2

berkowski opened this issue Jul 30, 2017 · 9 comments

Comments

@berkowski
Copy link
Owner

berkowski commented Jul 30, 2017

Development work in the serialport-2 branch.

@ndusart provided the majority of the API adaption with #1.

TODO:

  • Fix upstream issues until OSX/BSD targets compile (when nix v0.10 releases?)
  • Pull windows implementation @ndusart (Windows implementation #4)
  • Tag serialport-rs to a released version instead of git in Cargo.toml
  • Tag nix to a released version instead of git in Cargo.toml
@berkowski berkowski changed the title Be ready for serialport-rs v2.0 Be ready for serialport-rs v2.0 Jul 30, 2017
@Susurrus
Copy link

Well it was just released today, so I hope you're ready!

@berkowski
Copy link
Owner Author

Not quite ready, but then I'll never be ahead of things. I'll start looking into things this week.

@ndusart
Copy link
Contributor

ndusart commented Dec 19, 2017

Actually, if you want the build for OSX to pass, you'll have to wait that iokit-sys is fixed and published anyway ;-)

@berkowski
Copy link
Owner Author

First go looks promising: https://travis-ci.org/berkowski/mio-serial/builds/320715034

Unfortunately BSD targets don't look like they're going to work with nix 0.9

@Susurrus
Copy link

I'm hoping to have nix 0.10 released within the next couple of weeks. It's blocking on a single PR that's being reviewed right now so I think that's a realistic timeframe.

@berkowski
Copy link
Owner Author

Added #4 to the TODO list for serialport-2

@Susurrus
Copy link

Both nix 0.10 and serialport-rs 2.1 have been released, which should make this all ready to go on your end.

@ndusart
Copy link
Contributor

ndusart commented Feb 19, 2018

@berkowski yes, all points are resolved now
I updated #4 to use release 0.10 of nix and 2.1 of serialport

Thanks @Susurrus for all your work

@berkowski
Copy link
Owner Author

Things are good enough for me to merge the serialport-2 branch into master and start finalizing a new version release for mio and tokio. Thank you @ndusart and @Susurrus for all the work (and perhaps more, all the patience!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants