Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Library should assume default hashing algorithm of sha-256 #10

Open
TimoGlastra opened this issue Nov 29, 2023 · 1 comment
Open

Library should assume default hashing algorithm of sha-256 #10

TimoGlastra opened this issue Nov 29, 2023 · 1 comment

Comments

@TimoGlastra
Copy link
Contributor

The spec describes that if no _sd_alg property is present at the top-level, a default value of sha-256 MUST be used.

So I think we need to tweak the checkHasher method to use this as value to compare against the algorithm.

If the _sd_alg claim is not present at the top level, a default value of sha-256 MUST be used.

https://datatracker.ietf.org/doc/html/draft-ietf-oauth-selective-disclosure-jwt-06#name-hash-function-claim
@TimoGlastra
Copy link
Contributor Author

Might also be nice to add a sdAlg getter on the Sd JWt to get the property value, or the default if not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@TimoGlastra