Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(simulated): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority (3/4) #2523

Open
wants to merge 17 commits into
base: fix-coverage-measurement
Choose a base branch
from

Conversation

rezbera
Copy link
Contributor

@rezbera rezbera commented Feb 19, 2025

This PR builds on #2521 which needs to be merged first

This PR increases test coverage by adding the following tests:

  • TestFinalizeBlock_BadBlock_Errors effectively serves as a test for how a valid node would react to a malicious consensus majority agreeing to a block with an invalid EVM transaction.

  • TestProcessProposal_InvalidTimestamps_Errors effectively serves as a test for how a valid node would react to a malicious proposer attempting to use a future timestamp in the block that does not match the consensus timestamp.

  • TestProcessProposal_CrashedExecutionClient_Errors effectively serves as a test for how a valid node would react to a valid block being proposed but the execution client has crashed.

it also moves the tests to different files based on logical separation

@rezbera rezbera changed the title feat(simulation-tests): Add more simulation tests chore(simulation-tests): Add more simulation tests Feb 19, 2025
@rezbera rezbera changed the base branch from main to fix-coverage-measurement February 19, 2025 23:41
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 58.07%. Comparing base (3b01a62) to head (a73e594).

Additional details and impacted files

Impacted file tree graph

@@                     Coverage Diff                      @@
##           fix-coverage-measurement    #2523      +/-   ##
============================================================
+ Coverage                     56.77%   58.07%   +1.29%     
============================================================
  Files                           337      337              
  Lines                         14885    14885              
  Branches                         20       20              
============================================================
+ Hits                           8451     8644     +193     
+ Misses                         5783     5578     -205     
- Partials                        651      663      +12     

see 26 files with indirect coverage changes

@rezbera rezbera changed the title chore(simulation-tests): Add more simulation tests feat(simulation): Add more simulation tests Feb 20, 2025
@rezbera rezbera changed the title feat(simulation): Add more simulation tests test(simulation): Add more simulation tests Feb 20, 2025
@rezbera rezbera changed the title test(simulation): Add more simulation tests test(simulation): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority Feb 20, 2025
@rezbera rezbera marked this pull request as ready for review February 20, 2025 07:03
@rezbera rezbera requested a review from a team as a code owner February 20, 2025 07:03
@rezbera rezbera changed the title test(simulation): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority test(simulated): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority Feb 23, 2025
@rezbera rezbera changed the title test(simulated): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority test(simulated): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority (3/4) Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant