-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(simulated): Add Simulation Tests for Malicious Proposer, Crashed EL and Malicious Consensus Majority (3/4) #2523
Open
rezbera
wants to merge
17
commits into
fix-coverage-measurement
Choose a base branch
from
add-more-simulation-tests
base: fix-coverage-measurement
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+365
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix-coverage-measurement #2523 +/- ##
============================================================
+ Coverage 56.77% 58.07% +1.29%
============================================================
Files 337 337
Lines 14885 14885
Branches 20 20
============================================================
+ Hits 8451 8644 +193
+ Misses 5783 5578 -205
- Partials 651 663 +12 |
rezbera
commented
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR builds on #2521 which needs to be merged first
This PR increases test coverage by adding the following tests:
TestFinalizeBlock_BadBlock_Errors effectively serves as a test for how a valid node would react to a malicious consensus majority agreeing to a block with an invalid EVM transaction.
TestProcessProposal_InvalidTimestamps_Errors effectively serves as a test for how a valid node would react to a malicious proposer attempting to use a future timestamp in the block that does not match the consensus timestamp.
TestProcessProposal_CrashedExecutionClient_Errors effectively serves as a test for how a valid node would react to a valid block being proposed but the execution client has crashed.
it also moves the tests to different files based on logical separation