Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option to bypass Electron and empty host check #152

Open
Halyul opened this issue Jan 28, 2025 · 2 comments · May be fixed by #156
Open

Option to bypass Electron and empty host check #152

Halyul opened this issue Jan 28, 2025 · 2 comments · May be fixed by #156

Comments

@Halyul
Copy link

Halyul commented Jan 28, 2025

Hi, I have a very special case where I want to track file:// urls. As there is a check in trackPageview, I would like to know if an option to bypass the check can be added in the future.
@benvinegar
Copy link
Owner

Yep, I think we can figure this out.

@benvinegar benvinegar linked a pull request Feb 4, 2025 that will close this issue
Open
@benvinegar
Copy link
Owner

@Halyul Looked at this and thought it best just to remove the check entirely. Thoughts on #156?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Remove Electron early return benvinegar/counterscale
2 participants
@benvinegar @Halyul