Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move CJS build to to root #105

Open
benmvp opened this issue Mar 5, 2020 · 0 comments
Open

Move CJS build to to root #105

benmvp opened this issue Mar 5, 2020 · 0 comments
Labels
enhancement New feature or request

Comments

@benmvp
Copy link
Owner

benmvp commented Mar 5, 2020

🚀 Feature Proposal

Instead of putting the CJS build at lib/cjs, put it at lib/ so that it'll be at the root of the package. The esm/ folder will remain.

Motivation

This allows the package to do deep importing without having to reference the cjs/ folder.

Example

We want this:

import { getValue } from 'my-lib/getters'

Instead of:

import { getValue } from 'my-lib/cjs/getters'
@benmvp benmvp added the enhancement New feature or request label Mar 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant