Add newlines-between option to order rule
#298
Conversation
|
LGTM, but @jfmengels should have final say, it's his baby. 😊 |
|
Oh, actually, it would be great if you could add a note to the change log. |
| previousImport.node, 'There should be one empty line between import groups' | ||
| ) | ||
| } else if (currentImport.rank === previousImport.rank | ||
| && getLineDifference(currentImport, previousImport) === 2) |
|
This looks pretty good @singles, thanks a lot for this!
Man, you have no idea... I still haven't had the heart to deprecate |
|
I can imagine. But every download here is your download too, now! 😁 I think GitHub itself may be responsible for the recent uptick in downloads, so that's pretty cool. |
|
I think https://github.com/dustinspecker/awesome-eslint is partially responsible too. Even more so probably. |
|
OK, new changes:
Thx @benmosher @jfmengels for feedback! |
| @@ -7,6 +7,7 @@ This change log adheres to standards from [Keep a CHANGELOG](http://keepachangel | |||
| ### Added | |||
| - [`newline-after-import`], new rule. ([#245], thanks [@singles]) | |||
| - Added an `optionalDependencies` option to [`no-extraneous-dependencies`] to allow/forbid optional dependencies ([#266], thanks [@jfmengels]). | |||
| - Added `newlines-between` option to `order` rule ([#298], thanks [@singles]) | |||
There was a problem hiding this comment.
Could you put brackts around order so that there is a link there?
|
Sorry for the nitpicking, looks great otherwise @singles! |
Checks existence of new lines between and inside import groups.
No problem :) |
|
Looks pretty great to me :D |
|
|
Checks existence of new lines between and inside import groups.
Implements #282.