Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[New] no-cycle: add ignoreExternal option #1681

Closed
wants to merge 0 commits into from
Closed

[New] no-cycle: add ignoreExternal option #1681

wants to merge 0 commits into from

Conversation

sveyret
Copy link
Contributor

@sveyret sveyret commented Mar 11, 2020

Add an ignoreExternal option to no-cycle which prevent cycling detection to look into external modules.

Fixes #1647

@sveyret sveyret mentioned this pull request Mar 11, 2020
Closed
@sveyret
Copy link
Contributor Author

sveyret commented Mar 12, 2020

CI error is a timeout. Is it possible to re-execute the failing builds?

@golopot
Copy link
Contributor

golopot commented Mar 16, 2020

CI error is a timeout. Is it possible to re-execute the failing builds?

You can do a no-code-change git commit --amend and a force push. That will restart CI.

@coveralls
Copy link

coveralls commented Mar 16, 2020 •
edited
Loading

Coverage Status

Coverage increased (+0.004%) to 97.818% when pulling 5f02f6f on slune-org:cycle-external into 055389d on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.801% when pulling a5359df on slune-org:cycle-external into 1a3a128 on benmosher:master.

3 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.801% when pulling a5359df on slune-org:cycle-external into 1a3a128 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.801% when pulling a5359df on slune-org:cycle-external into 1a3a128 on benmosher:master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.004%) to 97.801% when pulling a5359df on slune-org:cycle-external into 1a3a128 on benmosher:master.

@ljharb ljharb mentioned this pull request Apr 2, 2020
Closed
@ljharb ljharb changed the title [Fix] no-cycle: add ignoreExternal option [New] no-cycle: add ignoreExternal option Apr 23, 2020
@ljharb

This comment has been minimized.

Sign in to view
@sveyret

This comment has been minimized.

Sign in to view
@ljharb

This comment has been minimized.

Sign in to view
@sveyret

This comment has been minimized.

Sign in to view
@ljharb
Copy link
Member

ljharb commented Apr 23, 2020

appveyor tests passed, but the coveralls code crashed. merging anyways.

@ljharb ljharb closed this Apr 23, 2020
@ljharb ljharb deleted the cycle-external branch April 23, 2020 19:34
@ljharb
Copy link
Member

ljharb commented Apr 23, 2020

This was merged in 73211e8

This was referenced Mar 18, 2021
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-minor
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[import/no-cycle] do not check node_modules
4 participants
@sveyret @golopot @coveralls @ljharb