fix(ui): fix rebalance indicator

src/Utils.js

@@ -1,5 +1,3 @@
-import * as Settings from './Settings'
-
 export default class Utils {
   static pad(width, string, padding) {
     return (width <= string.length) ? string : this.pad(width, padding + string, padding)
@@ -40,12 +38,12 @@ export default class Utils {
   }
 
   /**
-   * Determines if drift is above treshold defined in settings.
+   * Determines if drift is above the provided treshold.
    * @param drift The current drift.
+   * @param treshold The treshold.
    * @return {string} 'Y', if drifted, '' if not.
    */
-  static hasDriftedAboveTreshold(drift) {
-    return (Math.abs(drift) * 100 > (Settings.options.rebalanceDeltaTotalPct ||
-        Settings.options.rebalanceDeltaPct)) ? 'Y' : ''
+  static hasDriftedAboveTreshold(drift, treshold) {
+    return (Math.abs(drift) * 100 > treshold) ? 'Y' : ''
   }
 }

src/model/Portfolio.js

@@ -162,7 +162,7 @@ export default class Portfolio {
         Format.bitcoin((targetBtc - coin.getBtcValue()) / Coinmarket.getBtcEth(), 8),
         Format.money(targetUsd - coin.getUsdValue()),
         Format.percent(drift),
-        Utils.hasDriftedAboveTreshold(drift),
+        Utils.hasDriftedAboveTreshold(drift, Settings.options.rebalanceDeltaPct),
         coin.getExchangesString()
       ])
       targetSum['allocationActualPct'] += allocationActualPct || 0
@@ -186,7 +186,8 @@ export default class Portfolio {
       '',
       Format.money(targetSum['targetUsd'] - this.getSumUsd()),
       Format.percent(drift),
-      Utils.hasDriftedAboveTreshold(drift),
+      Utils.hasDriftedAboveTreshold(drift, (Settings.options.rebalanceDeltaTotalPct ||
+          Settings.options.rebalanceDeltaPct)),
       ''])
 
     // noinspection JSUnusedGlobalSymbols

test/testUtils.js

@@ -12,4 +12,9 @@ describe('Testing utils', () => {
     assert(Utils.round(1.5666, 2) === 1.57)
     assert(Utils.round(1.5666, 10) === 1.5666)
   })
+
+  it('Test hasDriftedAboveTreshold', () => {
+    assert(Utils.hasDriftedAboveTreshold(0.11, 10))
+    assert(!Utils.hasDriftedAboveTreshold(0.09, 10))
+  })
 })