Skip to content

Commit

Permalink
update to Go 1.23
Browse files Browse the repository at this point in the history
  • Loading branch information
benma committed Oct 23, 2024
1 parent dbb1189 commit fb543f2
Show file tree
Hide file tree
Showing 10 changed files with 15 additions and 15 deletions.
4 changes: 2 additions & 2 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ env:
# https://docs.github.com/en/packages/guides/pushing-and-pulling-docker-images
#
# Keep this in sync with default in scripts/github-ci.sh.
CI_IMAGE: ghcr.io/bitboxswiss/bitbox-wallet-app-ci:24
CI_IMAGE: ghcr.io/bitboxswiss/bitbox-wallet-app-ci:25
GITHUB_BUILD_DIR: ${{github.workspace}}

jobs:
Expand Down Expand Up @@ -99,7 +99,7 @@ jobs:
- name: Install Go
uses: actions/setup-go@v5
with:
go-version: 1.22.x
go-version: 1.23.x
- name: Install Node.js
uses: actions/setup-node@v4
with:
Expand Down
4 changes: 2 additions & 2 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

# options for analysis running
run:
go: "1.22"
go: "1.23"

# default concurrency is a available CPU number
concurrency: 4
Expand All @@ -23,7 +23,7 @@ run:
# output configuration options
output:
# colored-line-number|line-number|json|tab|checkstyle, default is "colored-line-number"
formats:
formats:
- format: colored-line-number
path: stdout

Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@ gomobileinit:
# Initializiation on MacOS
# - run make from $GOPATH/src/github.com/BitBoxSwiss/bitbox-wallet-app
# - additional dependencies: Qt 5.15 & Xcode command line tools
# - add to $PATH: /usr/local/opt/go@1.22/bin
# - add to $PATH: /usr/local/opt/go@1.23/bin
osx-init:
./scripts/osx-brew.sh
$(MAKE) envinit
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ The below instructions assume a unix environment.

To build the app or run the development workflow, the following dependencies need to be installed:

- [Go](https://golang.org/doc/install) version 1.22
- [Go](https://golang.org/doc/install) version 1.23
- [Node.js](https://nodejs.org/) version 20.x
- [NPM](https://docs.npmjs.com/about-npm-versions) version 10.x or newer
- [Qt5](https://www.qt.io) version 5.15.2
Expand Down
2 changes: 1 addition & 1 deletion appveyor.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ before_build:

build_script:
- echo on
- choco install go --version=1.22.6
- choco install go --version=1.23.2
- go version
- go env
- choco install make
Expand Down
6 changes: 3 additions & 3 deletions docs/BUILD.md
Original file line number Diff line number Diff line change
Expand Up @@ -30,11 +30,11 @@ Build artifacts:

## MacOS

Make sure you have `qt@5/bin`, `go@1.22/bin` and `go/bin` in your PATH, i.e. add to your `.zshrc`
Make sure you have `qt@5/bin`, `go@1.23/bin` and `go/bin` in your PATH, i.e. add to your `.zshrc`

```bash
export PATH="$PATH:/usr/local/opt/qt@5/bin"
export PATH="$PATH:/usr/local/opt/go@1.22/bin"
export PATH="$PATH:/usr/local/opt/go@1.23/bin"
export PATH="$PATH:$HOME/go/bin"
```

Expand Down Expand Up @@ -73,7 +73,7 @@ xcrun altool --list-providers --username "APPLE_ID" --password "PASSWORD"
The build requires `Microsoft Visual Studio 2019 Community Edition`, with the `MSVC v142 - VS 2019 C++ x64/x86 build tools (Latest)`
individual component.

It also requires `mingw-w64`, `bash` (e.g. `git-bash`), `make`,`go 1.22`, `node@20`, `QT 5.15.2` with `qtwebengine`, `nsis`
It also requires `mingw-w64`, `bash` (e.g. `git-bash`), `make`,`go 1.23`, `node@20`, `QT 5.15.2` with `qtwebengine`, `nsis`
and possibly other tools.

Some of the tools are easy to install with `choco`:
Expand Down
2 changes: 1 addition & 1 deletion go.mod
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
module github.com/BitBoxSwiss/bitbox-wallet-app

go 1.22
go 1.23

require (
github.com/BitBoxSwiss/bitbox02-api-go v0.0.0-20240925080402-a2115fee878e
Expand Down
2 changes: 1 addition & 1 deletion scripts/docker_install.sh
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ npm install -g npm@10
npm install -g locize-cli

mkdir -p /opt/go_dist
curl https://dl.google.com/go/go1.22.4.linux-amd64.tar.gz | tar -xz -C /opt/go_dist
curl https://dl.google.com/go/go1.23.2.linux-amd64.tar.gz | tar -xz -C /opt/go_dist

# fuse is needed to run the linuxdeployqt appimage.
apt-get install -y --no-install-recommends fuse
Expand Down
2 changes: 1 addition & 1 deletion scripts/github-ci.sh
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ if [ "$OS_NAME" == "linux" ]; then
# Which docker image to use to run the CI. Defaults to Docker Hub.
# Overwrite with CI_IMAGE=docker/image/path environment variable.
# Keep this in sync with .github/workflows/ci.yml.
: "${CI_IMAGE:=shiftcrypto/bitbox-wallet-app:24}"
: "${CI_IMAGE:=shiftcrypto/bitbox-wallet-app:25}"
# Time image pull to compare in the future.
time docker pull "$CI_IMAGE"

Expand Down
4 changes: 2 additions & 2 deletions scripts/osx-brew.sh
Original file line number Diff line number Diff line change
Expand Up @@ -3,12 +3,12 @@
if [ $(arch) = "arm64" ]; then
# recent M-based apple machines have an arm64 arch, but we need to install x86_64 deps
arch -x86_64 /bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
/usr/local/Homebrew/bin/brew install go@1.22
/usr/local/Homebrew/bin/brew install go@1.23
/usr/local/Homebrew/bin/brew install qt@5
/usr/local/Homebrew/bin/brew install create-dmg
else
/bin/bash -c "$(curl -fsSL https://raw.githubusercontent.com/Homebrew/install/master/install.sh)"
brew install go@1.22
brew install go@1.23
brew install qt@5
brew install create-dmg
fi

0 comments on commit fb543f2

Please sign in to comment.