Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make CurrentOffset long type? #161

Closed
wakuflair opened this issue Jun 28, 2024 · 2 comments
Closed

Make CurrentOffset long type? #161

wakuflair opened this issue Jun 28, 2024 · 2 comments

Comments

@wakuflair
Copy link

public static Parser<TToken, int> CurrentOffset { get; }

Hi @benjamin-hodgson
I'd like to use a long type CurrentOffset, as for large binary data, int may not be enough.

@benjamin-hodgson
Copy link
Owner

Great point, I obviously wasn't thinking and just defaulted to int. I'll have to make it a new API (ie CurrentOffsetLong or similar) so as not to break existing usages - any input on the naming?

@benjamin-hodgson
Copy link
Owner

Shipped in 3.3.0 https://www.nuget.org/packages/Pidgin/3.3.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants