Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moved typings dependencies to devDependencies #88

Merged
merged 1 commit into from
Sep 8, 2018

Conversation

emiyake
Copy link
Contributor

@emiyake emiyake commented Aug 20, 2018

@types/* should be added as devDependencies.

Otherwise, it could conflict with different versions of @type definition in the project, as follows:

./node_modules/react-native-masked-text/node_modules/@types/react-native/globals.d.ts(66,3): error TS2717: Subsequent property declarations must have the same type.  Property 'body' must be of type 'string | ArrayBuffer | ArrayBufferView | Blob | FormData', but here has type 'BodyInit_'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/globals.d.ts(92,14): error TS2300: Duplicate identifier 'RequestInfo'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/globals.d.ts(111,13): error TS2403: Subsequent variable declarations must have the same type.  Variable 'Response' must be of type '{ new (body?: any, init?: ResponseInit): Response; prototype: Response; error: () => Response; re...', but here has type '{ new (body?: BodyInit_, init?: ResponseInit): Response; prototype: Response; error: () => Respon...'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/index.d.ts(9010,11): error TS2451: Cannot redeclare block-scoped variable 'console'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/index.d.ts(9021,11): error TS2451: Cannot redeclare block-scoped variable 'navigator'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/index.d.ts(9031,11): error TS2451: Cannot redeclare block-scoped variable 'originalXMLHttpRequest'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/index.d.ts(9033,11): error TS2451: Cannot redeclare block-scoped variable '__BUNDLE_START_TIME__'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/index.d.ts(9034,11): error TS2451: Cannot redeclare block-scoped variable 'ErrorUtils'.
./node_modules/react-native-masked-text/node_modules/@types/react-native/index.d.ts(9041,11): error TS2451: Cannot redeclare block-scoped variable '__DEV__'.

@bhrott bhrott merged commit bfed6c2 into bhrott:master Sep 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants