Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python wrapper? #1

Open
MaxBenChrist opened this issue Sep 12, 2017 · 8 comments
Open

Python wrapper? #1

MaxBenChrist opened this issue Sep 12, 2017 · 8 comments

Comments

@MaxBenChrist
Copy link

Hi Ben :),

there was a question regarding synthetic time series generators in python, see

MaxBenChrist/awesome_time_series_in_python#7

Can you provide a python wrapper for this TimeSeriesGeneration package? Would love to include it in my list.

@benfulcher
Copy link
Owner

I'm not sure how to do the python wrapping of Matlab; Santi Villalba helped do this for hctsa a few years ago. But I'd be open to someone working this up! It's all very simple stuff that would be straightforward to reimplement

@MaxBenChrist
Copy link
Author

MaxBenChrist commented Sep 13, 2017

If you are interested, I think we can try to convert the matlab files directly into python code as you are mostly using basic arithmetic functions.

Here is a list of options to convert matlab to python code
https://stackoverflow.com/questions/9845292/a-tool-to-convert-matlab-code-to-python

especially this one looks promising

https://github.com/victorlei/smop

I will have a look at it later

@MaxBenChrist
Copy link
Author

I started converting the matlab code to python, see

https://github.com/MaxBenChrist/TimeSeriesGeneration

@benfulcher
Copy link
Owner

Nice! Look forward to seeing it develop 👍

@MaxBenChrist
Copy link
Author

Nice! Look forward to seeing it develop 👍

Shall we make a python package out of it? We can add an folder with the matlab source files inside that package. Or we open a new repo

@benfulcher
Copy link
Owner

Up to you! Happy for you to do what you like with it, if you properly credit the original source. I should add a license...

@MaxBenChrist
Copy link
Author

I would be in favor of having another clean repository, with both repositorys referencing each other.

I think I will have to rewrite quite a lot of the calculations. At the moment, smop is replacing the vectors by custom ndarrays (such that the indexing starts at 1 and not at 0). This dependency on smop is unecessary and I want to get rid of it.

@benfulcher
Copy link
Owner

benfulcher commented Sep 13, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants