Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor FileAttributes.js to line up with deprecation of metadata columns #140

Closed
johnhbenetech opened this issue Oct 2, 2020 · 1 comment

Comments

@johnhbenetech
Copy link
Member

After the latest changes to refactor dark filtering, several columns are no longer output to the DB (things like grey_avg)

There are now JS errors on the single video view page that are causing the page to not render. I could be wrong, but I believe the issue is lines like:

value: (file) => file.metadata.grayAverage.toFixed(2),

I believe the toFixed() function can't handle a null.

I added #139 to do a more thorough clean-up, but I'd like to expedite this task to get the pages rendering again

@johnhbenetech
Copy link
Member Author

@stepan-anokhin if you could take a quick look at this before continuing other tasks that would be awesome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant