Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SortedSetBuilder Doesn't Have a Mechanism To Return The Set #44

Closed
d80tb7 opened this issue Mar 1, 2023 · 1 comment · Fixed by #46
Closed

SortedSetBuilder Doesn't Have a Mechanism To Return The Set #44

d80tb7 opened this issue Mar 1, 2023 · 1 comment · Fixed by #46

Comments

@d80tb7
Copy link

d80tb7 commented Mar 1, 2023

As far as I can tell, SortedSetBuilder doesn't have a mechanism to allow the caller to retrieve the built Set. I propose adding a method, func(s SortedSetBuilder[T])()SortedSet[T] which is analogous to ListBuilder.List() and MapBuilder.Map() respectively.

Happy to make a PR for this if you think it's useful
@BarrensZeppelin
Copy link
Contributor

BarrensZeppelin commented Mar 1, 2023 •
edited
Loading

This is definitely an oversight. Feel free to submit a PR. 🙂

@d80tb7 d80tb7 mentioned this issue Mar 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expose sorted sets builder d80tb7/immutable
2 participants
@BarrensZeppelin @d80tb7